Page MenuHomePhabricator
Differential D12092

[commtest] Add test for initial device list
ClosedPublic
Actions

Authored by bartek on May 17 2024, 1:44 AM.
Tags
None
Referenced Files
F3154168: D12092.diff
Tue, Nov 5, 7:26 AM
Unknown Object (File)
Sat, Nov 2, 12:52 AM
Unknown Object (File)
Fri, Nov 1, 3:01 PM
Unknown Object (File)
Tue, Oct 15, 4:06 PM
Unknown Object (File)
Sun, Oct 13, 12:10 PM
Unknown Object (File)
Sun, Oct 13, 8:25 AM
Unknown Object (File)
Sat, Oct 12, 12:36 PM
Unknown Object (File)
Fri, Oct 11, 5:34 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
will
varun
Commits
rCOMMd3b9774af2c0: [commtest] Add test for initial device list
Summary

Added a commtest test for initial device list.

Depends on D12091

Test Plan

Commtest

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.May 17 2024, 1:44 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMay 17 2024, 1:44 AM
bartek published this revision for review.May 17 2024, 1:59 AM
Harbormaster completed remote builds in B29012: Diff 40321.May 17 2024, 2:00 AM
bartek added a reviewer: varun.May 20 2024, 1:15 AM
kamil accepted this revision.May 23 2024, 6:36 AM
This revision is now accepted and ready to land.May 23 2024, 6:36 AM
kamil added inline comments.May 23 2024, 6:37 AM
services/commtest/tests/identity_device_list_tests.rs
425 ↗(On Diff #40321)

worth adding check that history is empty

bartek updated this revision to Diff 40600.May 23 2024, 10:49 PM

Add assertion for history. Rebase before landing

Harbormaster completed remote builds in B29218: Diff 40600.May 23 2024, 11:04 PM
Closed by commit rCOMMd3b9774af2c0: [commtest] Add test for initial device list (authored by bartek). · Explain WhyMay 23 2024, 11:08 PM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMd3b9774af2c0: [commtest] Add test for initial device list.

Revision Contents
Changeset List

PathSize
services/
commtest/
src/
identity/
12 lines
tests/
91 lines

Diff 40600

View Options

services/commtest/src/identity/device.rs

Loading...
View Options

services/commtest/tests/identity_device_list_tests.rs

Loading...