Page MenuHomePhabricator
Differential D12350

[identity] Forbid registering multiple devices with the same ID
ClosedPublic
Actions

Authored by bartek on Jun 7 2024, 3:59 AM.
Tags
None
Referenced Files
F2833681: D12350.id41097.diff
Sat, Sep 28, 8:26 AM
Unknown Object (File)
Thu, Sep 12, 6:23 AM
Unknown Object (File)
Tue, Sep 10, 4:39 PM
Unknown Object (File)
Tue, Sep 10, 4:39 PM
Unknown Object (File)
Tue, Sep 10, 4:39 PM
Unknown Object (File)
Tue, Sep 10, 4:39 PM
Unknown Object (File)
Tue, Sep 10, 4:37 PM
Unknown Object (File)
Tue, Sep 10, 4:37 PM
View All 53 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
will
Commits
rCOMM19818e9af187: [identity] Forbid registering multiple devices with the same ID
Summary

Addresses ENG-8383.
We don't want to allow registering multiple users with the same device ID.
However, if given device ID belongs to the same user, we can allow that (details in Linear task).

Depends on D12349

Test Plan

Commtest: called register_user_device() twice with the same device keys. Second call failed due to Status::AlreadyExists

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Jun 7 2024, 3:59 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2024, 3:59 AM
Harbormaster failed remote builds in B29524: Diff 41097!Jun 7 2024, 4:04 AM
Harbormaster completed remote builds in B29524: Diff 41097.Jun 9 2024, 11:29 PM
bartek published this revision for review.Jun 9 2024, 11:52 PM
bartek added 1 blocking reviewer(s): varun.
varun accepted this revision.Jun 12 2024, 8:56 AM
This revision is now accepted and ready to land.Jun 12 2024, 8:56 AM
varun added a comment.Jun 12 2024, 9:04 AM

in the login RPCs, don't we need to check that the device ID doesn't belong to a different user if it already exists?

varun requested changes to this revision.Jun 12 2024, 9:05 AM
This revision now requires changes to proceed.Jun 12 2024, 9:05 AM
bartek updated this revision to Diff 41366.Jun 17 2024, 2:51 AM

Verify if device ID belongs to the same user

Harbormaster completed remote builds in B29706: Diff 41366.Jun 17 2024, 3:08 AM
bartek added inline comments.Jun 17 2024, 7:48 AM
services/identity/src/client_service.rs
1107 ↗(On Diff #41366)

I'm going to rebase on @varun's stack (when it's landed) before landing this and add a constant for this message

varun added inline comments.Jun 17 2024, 7:56 AM
services/identity/src/client_service.rs
1107 ↗(On Diff #41366)

thanks, will land my stack ASAP

varun accepted this revision.Jun 17 2024, 10:26 AM
This revision is now accepted and ready to land.Jun 17 2024, 10:26 AM
bartek updated this revision to Diff 41432.Jun 17 2024, 11:56 PM

Add constant for Tonic status code

Harbormaster completed remote builds in B29737: Diff 41432.Jun 18 2024, 12:11 AM
Closed by commit rCOMM19818e9af187: [identity] Forbid registering multiple devices with the same ID (authored by bartek). · Explain WhyJun 18 2024, 2:18 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM19818e9af187: [identity] Forbid registering multiple devices with the same ID.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
52 lines
database/
22 lines

Diff 41097

View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/database/device_list.rs

Loading...