Page MenuHomePhabricator

[identity] Add /inbound_keys HTTP handler
ClosedPublic

Authored by bartek on Jun 4 2024, 12:59 AM.
Tags
None
Referenced Files
F3346477: D12304.diff
Fri, Nov 22, 8:55 AM
Unknown Object (File)
Sat, Nov 16, 4:37 AM
Unknown Object (File)
Sat, Nov 16, 4:23 AM
Unknown Object (File)
Tue, Nov 5, 5:42 PM
Unknown Object (File)
Fri, Nov 1, 5:29 PM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Unknown Object (File)
Oct 13 2024, 5:05 AM
Subscribers

Details

Summary

Added HTTP endpoint for inbound keys. Request and response format described in ENG-8290.

Added some utility traits to leave handler with only business logic.

Depends on D12300, D12303

Test Plan

Registered a user with a few devices.

  • Called GetInboundKeysForUser RPC
  • Called /inbound_keys HTTP endpoint

Compared results.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jun 4 2024, 8:14 AM

I'll update this endpoint to return only single device

bartek added inline comments.
services/identity/src/http/mod.rs
25 ↗(On Diff #41096)

I'm considering naming this /device_inbound_keys to indicate it's a single-device endpoint

This revision is now accepted and ready to land.Jun 7 2024, 10:09 AM

Name endpoint /device_inbound_keys to indicate it's single-device. Rebase before landing.