Paths

Table of Contentst

[identity][terraform] Create DDB index for deviceID
ClosedPublic
Actions

Authored by bartek on Jun 7 2024, 3:55 AM.

Details

Reviewers

varun
will
marcin

Commits

rCOMM3b7dbcdd52f2: [identity][terraform] Create DDB index for deviceID

Summary

Addresses ENG-8382.
Introduced index to find devices only by deviceID.

Test Plan

terraform, localstack,

awslocal dynamodb scan --table-name identity-devices --index-name deviceID-index

returns userID, deviceID and loginTime attributes

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jun 7 2024, 3:55 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 7 2024, 3:55 AM

bartek added a child revision: D12349: [identity] Add function to query device by ID.Jun 7 2024, 3:57 AM

Harbormaster failed remote builds in B29521: Diff 41094!Jun 7 2024, 4:00 AM

CI unrelated

services/identity/src/constants.rs
138–141 ↗	(On Diff #41094)	Decided to restructure it a bit - login time is no longer a "migration-specific" attribute, but instead we have two "deprecated" attributes

Harbormaster completed remote builds in B29521: Diff 41094.Jun 10 2024, 3:13 AM

@will or @varun will do a better job reviewing this.

smart solution!

This revision is now accepted and ready to land.Jun 14 2024, 6:40 AM

Closed by commit rCOMM3b7dbcdd52f2: [identity][terraform] Create DDB index for deviceID (authored by bartek). · Explain WhyJun 17 2024, 2:54 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM3b7dbcdd52f2: [identity][terraform] Create DDB index for deviceID.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

constants.rs

11 lines

terraform/

modules/

shared/

dynamodb.tf

14 lines

Diff 41372

View Options

services/identity/src/constants.rs