Details
Details
- Reviewers
varun will kamil - Commits
- rCOMM17e30f45d3b8: [comm-lib] Verify CSAT in HTTP middleware
At this point, test plan from D12412 also requires credentials to be valid (token present in Identity).
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| shared/comm-lib/src/auth/types.rs | ||
|---|---|---|
| 44–46 | This is used only in low level logs (debug/trace). If this is still too dangerous, I'll remove the user_id entirely | |
| shared/comm-lib/src/auth/types.rs | ||
|---|---|---|
| 44–46 | Will these logs appear in production? | |
| shared/comm-lib/src/auth/types.rs | ||
|---|---|---|
| 44–46 | No, we need to explicitly lower log level to debug (we do it only on staging) or even lower to trace (I do it only locally in dev env) | |
| shared/comm-lib/src/auth/types.rs | ||
|---|---|---|
| 44–46 | Thanks for explaining! | |