Page MenuHomePhabricator
Differential D12525

[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker
ClosedPublic
Actions

Authored by kamil on Jun 20 2024, 3:33 PM.
Tags
None
Referenced Files
F3386844: D12525.diff
Fri, Nov 29, 6:28 AM
Unknown Object (File)
Sun, Nov 24, 9:21 AM
Unknown Object (File)
Thu, Nov 21, 1:59 AM
Unknown Object (File)
Sat, Nov 9, 9:59 AM
Unknown Object (File)
Fri, Nov 8, 10:36 PM
Unknown Object (File)
Fri, Nov 8, 1:29 PM
Unknown Object (File)
Fri, Nov 8, 12:24 PM
Unknown Object (File)
Oct 26 2024, 8:59 PM
View All 60 Files
Subscribers
tomek

Details

Reviewers
bartek
marcin
ashoat
Commits
rCOMM0de42f6fa609: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker
Summary

ENG-8400 (see point 5. Logout).

This RPC will be used by Identity to inform Tunnelbroker about device logout.

Now remove the device token. Creating a follow-up task to delete persisted messages to device (ENG-8495).

Test Plan

Tested in next diff

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jun 20 2024, 3:33 PM
kamil held this revision as a draft.
Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2024, 3:33 PM
kamil edited the summary of this revision. (Show Details)Jun 20 2024, 3:35 PM
kamil added a parent revision: D12520: [Tunnelbroker] implement setting device token.
kamil added a child revision: D12526: [Identity] remove Tunnelbroker data on device removal.Jun 20 2024, 3:36 PM
Harbormaster completed remote builds in B29847: Diff 41582.Jun 20 2024, 3:50 PM
kamil published this revision for review.Jun 20 2024, 4:10 PM
kamil mentioned this in D12538: [lib] introduce Tunnelbroker device token handler.Jun 21 2024, 2:45 AM
bartek added a comment.Jun 21 2024, 11:02 PM

What about undelivered_messages? Are they considered a "device data" too?

kamil added a comment.Jun 24 2024, 3:19 AM
In D12525#355420, @bartek wrote:

What about undelivered_messages? Are they considered a "device data" too?

Yes, I created a follow-up task to implement this too: ENG-8495.

kamil edited the summary of this revision. (Show Details)Jun 24 2024, 3:19 AM
bartek accepted this revision.Jun 25 2024, 12:00 AM
ashoat accepted this revision.Jun 30 2024, 5:55 PM

Can you remind me how we make sure that only Comm services can call DeleteDeviceData?

shared/protos/tunnelbroker.proto
30

Typo: extra space after message

This revision is now accepted and ready to land.Jun 30 2024, 5:55 PM
bartek added a comment.Jul 1 2024, 2:58 AM
In D12525#357103, @ashoat wrote:

Can you remind me how we make sure that only Comm services can call DeleteDeviceData?

Tunnelbroker gRPC port is exposed only to services

kamil updated this revision to Diff 41840.Jul 1 2024, 3:25 AM

remove extra space

Harbormaster completed remote builds in B30022: Diff 41840.Jul 1 2024, 3:42 AM
Closed by commit rCOMM0de42f6fa609: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker (authored by kamil). · Explain WhyJul 1 2024, 4:02 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0de42f6fa609: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker.
kamil mentioned this in rCOMM73cd11959193: [lib] introduce Tunnelbroker device token handler.Jul 1 2024, 6:33 AM

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
grpc/
18 lines
shared/
protos/
8 lines

Diff 41582

View Options

services/tunnelbroker/src/grpc/mod.rs

Loading...
View Options

shared/protos/tunnelbroker.proto

Loading...