[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker
ClosedPublic
Actions

Authored by kamil on Jun 20 2024, 10:33 PM.

Details

Reviewers

bartek
marcin
ashoat

Commits

rCOMM0de42f6fa609: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker

Summary

ENG-8400 (see point 5. Logout).

This RPC will be used by Identity to inform Tunnelbroker about device logout.

Now remove the device token. Creating a follow-up task to delete persisted messages to device (ENG-8495).

Test Plan

Tested in next diff

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Jun 20 2024, 10:33 PM

kamil held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptJun 20 2024, 10:33 PM

kamil edited the summary of this revision. (Show Details)Jun 20 2024, 10:35 PM

kamil added a parent revision: D12520: [Tunnelbroker] implement setting device token.

kamil added a child revision: D12526: [Identity] remove Tunnelbroker data on device removal.Jun 20 2024, 10:36 PM

Harbormaster completed remote builds in B29847: Diff 41582.Jun 20 2024, 10:50 PM

kamil published this revision for review.Jun 20 2024, 11:10 PM

kamil mentioned this in D12538: [lib] introduce Tunnelbroker device token handler.Jun 21 2024, 9:45 AM

What about undelivered_messages? Are they considered a "device data" too?

In D12525#355420, @bartek wrote:

What about undelivered_messages? Are they considered a "device data" too?

Yes, I created a follow-up task to implement this too: ENG-8495.

kamil edited the summary of this revision. (Show Details)Jun 24 2024, 10:19 AM

bartek accepted this revision.Jun 25 2024, 7:00 AM

Can you remind me how we make sure that only Comm services can call DeleteDeviceData?

shared/protos/tunnelbroker.proto
30	Typo: extra space after `message`

This revision is now accepted and ready to land.Jul 1 2024, 12:55 AM

In D12525#357103, @ashoat wrote:

Can you remind me how we make sure that only Comm services can call DeleteDeviceData?

Tunnelbroker gRPC port is exposed only to services

remove extra space

Harbormaster completed remote builds in B30022: Diff 41840.Jul 1 2024, 10:42 AM

Closed by commit rCOMM0de42f6fa609: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker. · Explain WhyJul 1 2024, 11:02 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM0de42f6fa609: [proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker.

kamil mentioned this in rCOMM73cd11959193: [lib] introduce Tunnelbroker device token handler.Jul 1 2024, 1:33 PM

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

grpc/

mod.rs

18 lines

shared/

protos/

tunnelbroker.proto

8 lines

Diff 41582

View Options

services/tunnelbroker/src/grpc/mod.rs