[native] fix button container height in RemoveTagButton
ClosedPublic
Actions

Authored by ginsu on Jun 20 2024, 8:33 PM.

Details

Reviewers

kamil
inka

Commits

rCOMMf772adbc5483: [native] fix button container height in RemoveTagButton

Summary

As I was factoring out logic for the remove tag button, noticed a small issue where the button was slightly shifting the height of the panel a few pixels when the content was going from "Remove tag" to the loading spinner. We should set the height of the button container so that this does not happen

Depends on D12532

Test Plan

Confirmed that the height of the button container remained the same when switching between loading and non-loading state

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Jun 20 2024, 8:33 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 20 2024, 8:33 PM

ginsu edited the summary of this revision. (Show Details)Jun 20 2024, 8:34 PM

ginsu added reviewers: kamil, inka.

ginsu added a parent revision: D12532: [lib/native] introduce useRemoveFarcasterChannelTag.

ginsu added inline comments.

native/community-settings/tag-farcaster-channel/remove-tag-button.react.js
42 ↗	(On Diff #41592)	`TagChannelButton` does the same https://github.com/CommE2E/comm/blob/master/native/community-settings/tag-farcaster-channel/tag-channel-button.react.js#L187
62 ↗	(On Diff #41592)	Already introduced the style here just forgot to call it smh