Page MenuHomePhabricator

[web] handle case where user needs to log in from native first
ClosedPublic

Authored by varun on Jun 21 2024, 4:44 PM.
Tags
None
Referenced Files
F3273602: D12545.id41627.diff
Sat, Nov 16, 6:11 AM
Unknown Object (File)
Sat, Nov 9, 6:48 AM
Unknown Object (File)
Fri, Nov 8, 6:13 AM
Unknown Object (File)
Sat, Nov 2, 12:04 PM
Unknown Object (File)
Sat, Nov 2, 4:50 AM
Unknown Object (File)
Fri, Nov 1, 9:33 AM
Unknown Object (File)
Tue, Oct 29, 9:49 PM
Unknown Object (File)
Thu, Oct 24, 3:11 AM
Subscribers

Details

Summary

an unknown error here is not very helpful, so we should explain to the user why login failed and instruct them to try from native

would normally add @ashoat since this diff introduces new copy. happy to incorporate any feedback when he returns

Depends on D12544

Test Plan

tested later in stack by registering a password and wallet user directly with my keyserver, which in turn called identity and added the address and username to the reserved usernames table

then, i flipped usingCSAT to true and tried logging in from web, which failed and displayed a message saying to log in from a mobile device

Screenshot 2024-06-21 at 8.13.05 PM.png (1×1 px, 166 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Jun 21 2024, 5:00 PM

Should the secondary title say "Wallet Connected" on error?

This revision is now accepted and ready to land.Jun 24 2024, 12:27 AM
In D12545#355460, @inka wrote:

Should the secondary title say "Wallet Connected" on error?

It does look a little strange to me, too, but I think we should wait until @ashoat is back to remove it

https://linear.app/comm/issue/ENG-8525/reconsider-wallet-connected-secondary-title-on-error