Page MenuHomePhabricator
Differential D12586

[lib][native] Add logOutPrimaryDevice to Identity Client
ClosedPublic
Actions

Authored by bartek on Thu, Jun 27, 7:18 AM.
Tags
None
Referenced Files
F2186835: D12586.diff
Thu, Jul 4, 4:30 AM
Unknown Object (File)
Wed, Jul 3, 1:09 PM
Unknown Object (File)
Wed, Jul 3, 10:08 AM
Unknown Object (File)
Tue, Jul 2, 2:14 PM
Unknown Object (File)
Mon, Jul 1, 7:58 PM
Unknown Object (File)
Mon, Jul 1, 12:06 PM
Unknown Object (File)
Sun, Jun 30, 12:57 PM
Unknown Object (File)
Sat, Jun 29, 5:28 PM
View All 12 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
varun
Commits
rCOMMdf174019f71a: [lib][native] Add logOutPrimaryDevice to Identity Client
Summary

Added logOutPrimaryDevice function to identity client context.
Similarly to e.g. registerPasswordUser, it creates singleton device list on its own.

Renamed createInitialDeviceList to createSingletonDeviceList - this name is more universal.
It can be also re-used during backup restore.

Depends on D12585

Test Plan

Tested against local identity. Confirmed that when identityClient.logOutPrimaryDevice() is called,
identity service receives valid device list payload.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Thu, Jun 27, 7:18 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptThu, Jun 27, 7:18 AM
bartek mentioned this in D12587: [identity] Rename verify_initial_device_list to verify_singleton_device_list.Thu, Jun 27, 7:26 AM
bartek mentioned this in D12590: [identity] Implement LogOutPrimaryDevice RPC.Thu, Jun 27, 7:38 AM
Harbormaster failed remote builds in B29951: Diff 41748!Thu, Jun 27, 7:42 AM
bartek updated this revision to Diff 41754.Thu, Jun 27, 7:42 AM

Rebase

Harbormaster completed remote builds in B29957: Diff 41754.Thu, Jun 27, 8:25 AM
bartek published this revision for review.Thu, Jun 27, 8:34 AM
bartek added a child revision: D12603: [lib] Add usePrimaryDeviceLogOut hook.Fri, Jun 28, 2:09 AM
kamil accepted this revision.Mon, Jul 1, 3:14 AM
This revision is now accepted and ready to land.Mon, Jul 1, 3:14 AM
bartek mentioned this in rCOMM9e9735538ea8: [identity] Rename verify_initial_device_list to verify_singleton_device_list.Tue, Jul 2, 11:52 PM
Closed by commit rCOMMdf174019f71a: [lib][native] Add logOutPrimaryDevice to Identity Client (authored by bartek). · Explain WhyWed, Jul 3, 3:08 AM
This revision was automatically updated to reflect the committed changes.
bartek mentioned this in rCOMM33f97a51114a: [identity] Implement LogOutPrimaryDevice RPC.
bartek added a commit: rCOMMdf174019f71a: [lib][native] Add logOutPrimaryDevice to Identity Client.

Revision Contents
Changeset List

PathSize
lib/
shared/
4 lines
6 lines
types/
3 lines
native/
identity-service/
23 lines

Diff 41748

View Options

lib/shared/device-list-utils.js

Loading...
View Options

lib/shared/device-list-utils.test.js

Loading...
View Options

lib/types/identity-service-types.js

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...