Details
Tested in next diff
Diff Detail
- Repository
- rCOMM Comm
- Branch
- land-token
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Can you remind me how we make sure that only Comm services can call DeleteDeviceData?
shared/protos/tunnelbroker.proto | ||
---|---|---|
30 ↗ | (On Diff #41582) | Typo: extra space after message |
This logic is a bit confusing.
I guess the reason we decided to store a separate deviceToken per keyserver is because we want to know if we've shared our deviceToken to that keyserver yet, not because we expect to have a different deviceToken per keyserver.
It would probably make more sense if we have a deviceTokenHasBeenUploaded: boolean in KeyserverInfo, and a deviceToken field at the top level of Redux. But we'll likely end up removing deviceTokens from keyservers soon anyways...