Page MenuHomePhabricator

[proto][Tunnelbroker] add RPC to delete device data from Tunnelbroker
ClosedPublic

Authored by kamil on Jun 20 2024, 3:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 9:33 PM
Unknown Object (File)
Wed, Sep 25, 9:32 PM
Unknown Object (File)
Wed, Sep 25, 9:32 PM
Unknown Object (File)
Sat, Sep 7, 1:40 PM
Unknown Object (File)
Sat, Sep 7, 1:39 PM
Unknown Object (File)
Sep 4 2024, 9:41 PM
Unknown Object (File)
Aug 26 2024, 3:21 PM
Unknown Object (File)
Aug 26 2024, 3:21 PM
Subscribers

Details

Summary

ENG-8400 (see point 5. Logout).

This RPC will be used by Identity to inform Tunnelbroker about device logout.

Now remove the device token. Creating a follow-up task to delete persisted messages to device (ENG-8495).

Test Plan

Tested in next diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jun 20 2024, 4:10 PM

What about undelivered_messages? Are they considered a "device data" too?

What about undelivered_messages? Are they considered a "device data" too?

Yes, I created a follow-up task to implement this too: ENG-8495.

Can you remind me how we make sure that only Comm services can call DeleteDeviceData?

shared/protos/tunnelbroker.proto
30 ↗(On Diff #41582)

Typo: extra space after message

This revision is now accepted and ready to land.Jun 30 2024, 5:55 PM

Can you remind me how we make sure that only Comm services can call DeleteDeviceData?

Tunnelbroker gRPC port is exposed only to services