Page MenuHomePhabricator

[landing] extend exiting competitor comparison code to handle new differentiation section
ClosedPublic

Authored by ginsu on Jul 1 2024, 7:16 AM.
Tags
None
Referenced Files
F3671885: D12629.id41851.diff
Mon, Jan 6, 4:27 AM
Unknown Object (File)
Sat, Jan 4, 4:36 PM
Unknown Object (File)
Sat, Jan 4, 4:36 PM
Unknown Object (File)
Sat, Jan 4, 4:36 PM
Unknown Object (File)
Sat, Jan 4, 4:36 PM
Unknown Object (File)
Sat, Jan 4, 2:33 AM
Unknown Object (File)
Wed, Dec 18, 5:00 AM
Unknown Object (File)
Nov 12 2024, 8:28 AM
Subscribers

Details

Summary

This diff extends our preexiting logic for the competitor comparison to better handle a new section explaining how Comm is differentiated. At the moment, the copy is not ready and given that I will be leaving in a few days, I made the copy for this new section just be lorum ipsum dummy text that should be easy to update and replace.

Test Plan

flow + confirmed later on in the stack that the new section was properly introduced

Screenshot 2024-07-01 at 10.18.36 AM.png (2×3 px, 904 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: inka, ashoat.
landing/competitor-logo.react.js
21

In this new section we are not directly comparing with a specific competitor so I felt that it made most sense that for this new "general" differentiation section had no logo/icon

ginsu requested review of this revision.Jul 1 2024, 7:33 AM
This revision is now accepted and ready to land.Jul 1 2024, 5:45 PM