Page MenuHomePhabricator
Differential D12713

[lib] make useJoinCommunity compatible with the auto join community handler
ClosedPublic
Actions

Authored by ginsu on Jul 9 2024, 11:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 17, 1:15 AM
Unknown Object (File)
Wed, Apr 9, 1:18 PM
Unknown Object (File)
Wed, Apr 9, 9:49 AM
Unknown Object (File)
Wed, Apr 9, 6:54 AM
Unknown Object (File)
Wed, Apr 9, 12:32 AM
Unknown Object (File)
Tue, Apr 8, 11:28 PM
Unknown Object (File)
Mon, Apr 7, 8:20 PM
Unknown Object (File)
Wed, Apr 2, 4:43 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
ashoat
inka
Commits
rCOMMc28089f95107: [lib] make useJoinCommunity compatible with the auto join community handler
Summary

This diff updates useJoinCommunity to be more agnostic so that this hook can be used for both invite links + auto join community handler

Depends on D12706

Test Plan

flow + confirmed that there were no regressions with the joining a community through accepitng an invite link user flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jul 9 2024, 11:27 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 9 2024, 11:27 PM
ginsu edited the summary of this revision. (Show Details)Jul 9 2024, 11:37 PM
ginsu added reviewers: ashoat, inka.
ginsu added a parent revision: D12706: [lib] introduce useJoinCommunity.
Harbormaster completed remote builds in B30256: Diff 42196.Jul 9 2024, 11:48 PM
ginsu requested review of this revision.Jul 9 2024, 11:48 PM
ginsu added a child revision: D12714: [native] update AutoJoinCommunityHandler to use useJoinCommunity hook.Jul 10 2024, 2:10 AM
ashoat accepted this revision.Jul 10 2024, 10:56 AM
This revision is now accepted and ready to land.Jul 10 2024, 10:56 AM
ginsu updated this revision to Diff 42219.Jul 10 2024, 11:56 PM

update

Harbormaster completed remote builds in B30277: Diff 42219.Jul 11 2024, 12:13 AM
ginsu updated this revision to Diff 42245.Jul 11 2024, 8:56 PM

rebase before landing

This revision was landed with ongoing or failed builds.Jul 11 2024, 9:01 PM
Closed by commit rCOMMc28089f95107: [lib] make useJoinCommunity compatible with the auto join community handler (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc28089f95107: [lib] make useJoinCommunity compatible with the auto join community handler.
Harbormaster completed remote builds in B30297: Diff 42245.Jul 11 2024, 9:12 PM

Revision Contents
Changeset List

PathSize
lib/
shared/
19 lines

Diff 42196

View Options

lib/shared/community-utils.js

Show All 34 Lines
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { DBOpsHandler } from 'lib/handlers/db-ops-handler.react.js'; import { DBOpsHandler } from 'lib/handlers/db-ops-handler.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js'; import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { MissingRegistrationDataHandler } from './account/registration/missing-registration-data/missing-registration-data-handler.react.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js'; import { BottomSheetProvider } from './bottom-sheet/bottom-sheet-provider.react.js';
import ChatContextProvider from './chat/chat-context-provider.react.js'; import ChatContextProvider from './chat/chat-context-provider.react.js';
import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js'; import MessageEditingContextProvider from './chat/message-editing-context-provider.react.js';
import AccessTokenHandler from './components/access-token-handler.react.js'; import AccessTokenHandler from './components/access-token-handler.react.js';
import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js'; import { FeatureFlagsProvider } from './components/feature-flags-provider.react.js';
▲ Show 20 Lines • Show All 242 Lines • ▼ Show 20 Lines navigation = (
<ChatContextProvider> <ChatContextProvider>
<DeepLinksContextProvider> <DeepLinksContextProvider>
<ChatMentionContextProvider> <ChatMentionContextProvider>
<RootNavigator /> <RootNavigator />
</ChatMentionContextProvider> </ChatMentionContextProvider>
</DeepLinksContextProvider> </DeepLinksContextProvider>
</ChatContextProvider> </ChatContextProvider>
<NavigationHandler /> <NavigationHandler />
<MissingRegistrationDataHandler />
</BottomSheetModalProvider> </BottomSheetModalProvider>
</NavigationContainer> </NavigationContainer>
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines