Details

Reviewers

kamil
marcin

Commits

rCOMMc9450a3b9890: [lib] Enable automatic retries for some messages

Summary

Modify processOutboundP2PMessages function so that it sends all automatically_retried messages when called without parameters. Add an effect scheduling the retry job.

https://linear.app/comm/issue/ENG-8729/automatic-retries-for-non-composable-dms

Depends on D12746

Test Plan

Tested on both native and web: modified our text message sending logic so that DMOps are generated and scheduled when we send a message:

Sent a message and checked if sending messages was attempted.
Modified the logic in processOutboundP2PMessages so that every other message fails. Checked if the retry was attempted after 30s.

Diff Detail

Repository

rCOMM Comm

Branch

dms (branched from palys-swm/dms)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jul 15 2024, 4:23 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 15 2024, 4:23 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 4:55 AM

Harbormaster failed remote builds in B30325: Diff 42287!

tomek added a child revision: D12749: [lib] Stop requiring sequential messages.Jul 15 2024, 5:04 AM

Rebase

Harbormaster completed remote builds in B30381: Diff 42344.Jul 16 2024, 5:25 AM

tomek requested review of this revision.Jul 16 2024, 5:25 AM

ashoat added inline comments.Jul 16 2024, 7:26 AM

lib/tunnelbroker/peer-to-peer-context.js
57 ↗	(On Diff #42344)	Probably missed this in an earlier diff, but why are we representing true as `'1'`?

tomek added inline comments.Jul 17 2024, 5:23 AM

lib/tunnelbroker/peer-to-peer-context.js
57 ↗	(On Diff #42344)	I had some trouble finding a layer where we can convert SQLite "boolean" - INTEGER into the JS boolean and decided that using a string instead is safe and easy. Looked again at it and found an easy solution - I'm going to update the diffs with it.