Page MenuHomePhabricator
Differential D12766

[Tunnelbroker] implement FCM Access Token lifetime
ClosedPublic
Actions

Authored by kamil on Jul 16 2024, 1:21 AM.
Tags
None
Referenced Files
F3359527: D12766.diff
Sun, Nov 24, 9:34 AM
Unknown Object (File)
Sat, Nov 2, 2:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Fri, Nov 1, 10:18 AM
Unknown Object (File)
Thu, Oct 31, 3:38 AM
View All 52 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
marcin
Commits
rCOMMcb4ca298599a: [Tunnelbroker] implement FCM Access Token lifetime
Summary

Implementing what is described in Google's OAuth 2.0 for Server to Server Applications.

Depends on D12765

Test Plan

Call get_auth_bearer and make sure it's regenerated when needed. Later in the stack I tested both sending notif with correct and incorrect access token

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jul 16 2024, 1:21 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 16 2024, 1:21 AM
kamil added a child revision: D12767: [Tunnelbroker] implement messages types to FCM service.Jul 16 2024, 1:23 AM
Harbormaster completed remote builds in B30361: Diff 42323.Jul 16 2024, 1:38 AM
kamil published this revision for review.Jul 16 2024, 2:38 AM
kamil edited the test plan for this revision. (Show Details)
kamil added inline comments.
services/tunnelbroker/src/notifs/fcm/token.rs
103–104

FCM_ACCESS_TOKEN_GENERATION_THRESHOLD is to handle time between this check and actual API call to send Firebase message

bartek mentioned this in D12754: [Tunnelbroker] implement OAuth 2.0 JWT token encoding.Jul 18 2024, 7:15 AM
bartek accepted this revision.Jul 18 2024, 7:19 AM
bartek added inline comments.
services/tunnelbroker/src/notifs/fcm/token.rs
98

IMO a bit more natural

This revision is now accepted and ready to land.Jul 18 2024, 7:19 AM
kamil updated this revision to Diff 42518.Jul 19 2024, 2:18 AM

rename

Harbormaster completed remote builds in B30505: Diff 42518.Jul 19 2024, 2:34 AM
Closed by commit rCOMMcb4ca298599a: [Tunnelbroker] implement FCM Access Token lifetime (authored by kamil). · Explain WhyJul 19 2024, 5:05 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMcb4ca298599a: [Tunnelbroker] implement FCM Access Token lifetime.

Revision Contents
Changeset List

PathSize
services/
tunnelbroker/
src/
1 line
notifs/
fcm/
40 lines

Diff 42323

View Options

services/tunnelbroker/src/constants.rs

Loading...
View Options

services/tunnelbroker/src/notifs/fcm/token.rs

Loading...