This follows a similar approach outlined in D8552. I was inspired by searching the string "BindingType<std::optional" on GitHub. This project provided a good implementation.
Depends on D12735
Differential D12736
[web] add std::optional (C++) <-> undefined (JS) marshalling ashoat on Jul 14 2024, 6:06 PM. Authored by Tags None Referenced Files
Subscribers None
Details This follows a similar approach outlined in D8552. I was inspired by searching the string "BindingType<std::optional" on GitHub. This project provided a good implementation. Depends on D12735 I tested this as part of the getLatestMessageEdit API I introduce later in this stack. I tested that on both web and iOS, which required using the std::optional <-> undefined marshalling
Diff Detail
Event TimelineComment Actions It's great to see these bindings! At some point, we should delete NullableString and NullableInt. The diff looks reasonable but @kamil should also take a look. Comment Actions I ended up not needing this, since I'm replacing the getLatestMessageEdit API with a getRelatedMessages API that returns an array. That said, I think it's still work landing. Going to separate it out from the rest of my stack though. Comment Actions
Task with some context: ENG-5719. |