Details

Reviewers

kamil
marcin

Commits

rCOMMb2e49dd51ea2: [native][web] Add a method fetching messages by ID

Summary

This allows retrying messages generated by a single action.

https://linear.app/comm/issue/ENG-8675/add-option-to-manually-retry-a-message

Depends on D12743

Test Plan

Tested in combination with the rest of the stack. Sending messages requires calling this API so checking if messages are sent tests it.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

tomek created this revision.Jul 15 2024, 11:05 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 15 2024, 11:05 AM

tomek added a child revision: D12745: [native][web] Introduce a method fetching messages by ID to SQLiteAPI.Jul 15 2024, 11:13 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 11:25 AM

Harbormaster failed remote builds in B30321: Diff 42282!

Rename, fix compilation issue

Harbormaster completed remote builds in B30378: Diff 42341.Jul 16 2024, 12:06 PM

tomek requested review of this revision.Jul 16 2024, 12:06 PM

Rebase

Harbormaster completed remote builds in B30409: Diff 42380.Jul 17 2024, 12:46 PM

Rebase

Harbormaster completed remote builds in B30416: Diff 42388.Jul 17 2024, 3:37 PM

tomek edited the test plan for this revision. (Show Details)Jul 17 2024, 4:20 PM

kamil accepted this revision.Jul 18 2024, 1:04 PM

kamil added inline comments.

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h
79 ↗	(On Diff #42388)	shouldn't this be `getAllEntitiesByPrimaryKeys`?

This revision is now accepted and ready to land.Jul 18 2024, 1:04 PM

Rename

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h
79 ↗	(On Diff #42388)	Yes, it should

Harbormaster completed remote builds in B30473: Diff 42472.Jul 18 2024, 3:27 PM

Closed by commit rCOMMb2e49dd51ea2: [native][web] Add a method fetching messages by ID. · Explain WhyJul 19 2024, 2:47 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMb2e49dd51ea2: [native][web] Add a method fetching messages by ID.

[native][web] Add a method fetching messages by ID
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 42380

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/schema/CommCoreModuleSchema.js

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm-query-executor.js

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/outbound-p2p-message-queries.test.js

web/shared-worker/types/sqlite-query-executor.js

[native][web] Add a method fetching messages by IDClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 42380

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

native/cpp/CommonCpp/_generated/commJSI.h

native/schema/CommCoreModuleSchema.js

web/cpp/SQLiteQueryExecutorBindings.cpp

web/shared-worker/_generated/comm-query-executor.js

web/shared-worker/_generated/comm_query_executor.wasm

web/shared-worker/queries/outbound-p2p-message-queries.test.js

web/shared-worker/types/sqlite-query-executor.js

[native][web] Add a method fetching messages by ID
ClosedPublic
Actions

Revision Contents
Changeset List