Add a field that marks messages as being subjects to automatic retries.
https://linear.app/comm/issue/ENG-8729/automatic-retries-for-non-composable-dms
Details
Details
Open an existing app and check if the migration doesn't throw. Start a fresh app and check if the DB creation succeeds. Further testing is performed later in the stack.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 2521–2522 ↗ | (On Diff #42279) | These changes were made by clang-format-all |
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 689 ↗ | (On Diff #42279) | This column name comes across as "past tense", basically indicating whether this message has been automatically retried. But from the diff description, it seems like it's more about whether the message CAN be automatically retried. Should we consider something like "can_be_automatically_retried" or "supports_automatic_retry" or "supports_auto_retry"? |
| 812 ↗ | (On Diff #42279) | Nit: typo (missing space) |
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 689 ↗ | (On Diff #42279) | agree with that |
Comment Actions
Rename column
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 689 ↗ | (On Diff #42279) | Makes sense - renamed to supports_auto_retry |
Comment Actions
Heads-up that I landed a different migration 48 in D12759, so you'll have to rebase this one. Sorry about that!