Page MenuHomePhabricator
Differential D12744

[native][web] Add a method fetching messages by ID
ClosedPublic
Actions

Authored by tomek on Jul 15 2024, 4:05 AM.
Tags
None
Referenced Files
F3003491: D12744.id42540.diff
Fri, Oct 18, 10:25 AM
Unknown Object (File)
Mon, Oct 14, 7:00 AM
Unknown Object (File)
Thu, Oct 10, 5:26 AM
Unknown Object (File)
Fri, Oct 4, 3:29 AM
Unknown Object (File)
Thu, Sep 26, 10:09 AM
Unknown Object (File)
Wed, Sep 25, 7:05 PM
Unknown Object (File)
Sep 15 2024, 10:07 AM
Unknown Object (File)
Sep 15 2024, 10:05 AM
View All 32 Files
Subscribers
ashoat

Details

Reviewers
kamil
marcin
Commits
rCOMMb2e49dd51ea2: [native][web] Add a method fetching messages by ID
Summary

This allows retrying messages generated by a single action.

https://linear.app/comm/issue/ENG-8675/add-option-to-manually-retry-a-message

Depends on D12743

Test Plan

Tested in combination with the rest of the stack. Sending messages requires calling this API so checking if messages are sent tests it.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Jul 15 2024, 4:05 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 15 2024, 4:05 AM
tomek added a child revision: D12745: [native][web] Introduce a method fetching messages by ID to SQLiteAPI.Jul 15 2024, 4:13 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 15 2024, 4:25 AM
Harbormaster failed remote builds in B30321: Diff 42282!
tomek updated this revision to Diff 42341.Jul 16 2024, 4:41 AM

Rename, fix compilation issue

Harbormaster completed remote builds in B30378: Diff 42341.Jul 16 2024, 5:06 AM
tomek requested review of this revision.Jul 16 2024, 5:06 AM
tomek updated this revision to Diff 42380.Jul 17 2024, 5:31 AM

Rebase

Harbormaster completed remote builds in B30409: Diff 42380.Jul 17 2024, 5:46 AM
tomek updated this revision to Diff 42388.Jul 17 2024, 8:21 AM

Rebase

Harbormaster completed remote builds in B30416: Diff 42388.Jul 17 2024, 8:37 AM
tomek edited the test plan for this revision. (Show Details)Jul 17 2024, 9:20 AM
kamil accepted this revision.Jul 18 2024, 6:04 AM
kamil added inline comments.
native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h
79 ↗(On Diff #42388)

shouldn't this be getAllEntitiesByPrimaryKeys?

This revision is now accepted and ready to land.Jul 18 2024, 6:04 AM
tomek updated this revision to Diff 42472.Jul 18 2024, 8:08 AM

Rename

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h
79 ↗(On Diff #42388)

Yes, it should

Harbormaster completed remote builds in B30473: Diff 42472.Jul 18 2024, 8:27 AM
Closed by commit rCOMMb2e49dd51ea2: [native][web] Add a method fetching messages by ID (authored by tomek). · Explain WhyJul 19 2024, 7:47 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMb2e49dd51ea2: [native][web] Add a method fetching messages by ID.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
2 lines
2 lines
24 lines
entities/
28 lines
NativeModules/
2 lines
57 lines
_generated/
schema/
3 lines
web/
cpp/
3 lines
shared-worker/
_generated/
queries/
16 lines
types/
3 lines

Diff 42540

View Options

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...
View Options

native/cpp/CommonCpp/DatabaseManagers/entities/EntityQueryHelpers.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/commJSI.h

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...
View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/shared-worker/_generated/comm-query-executor.js

Loading...
View Options

web/shared-worker/_generated/comm_query_executor.wasm

Loading...
View Options

web/shared-worker/queries/outbound-p2p-message-queries.test.js

Loading...
View Options

web/shared-worker/types/sqlite-query-executor.js

Loading...