[lib] Fix an invalid condition
ClosedPublic
Actions

Authored by tomek on Jul 16 2024, 6:14 AM.

Tags

None

Referenced Files

	F3387205: D12775.id42544.diff
	Fri, Nov 29, 8:14 AM

	F3386818: D12775.diff
	Fri, Nov 29, 6:21 AM

	Unknown Object (File)
	Mon, Nov 25, 10:57 PM

	Unknown Object (File)
	Sat, Nov 9, 8:10 AM

	Unknown Object (File)
	Fri, Nov 8, 5:12 PM

	Unknown Object (File)
	Oct 23 2024, 7:23 PM

	Unknown Object (File)
	Oct 23 2024, 7:23 PM

	Unknown Object (File)
	Oct 23 2024, 7:21 PM

View All 53 Files

Subscribers

ashoat

Details

Reviewers

kamil
marcin

Commits

rCOMM5eba6c1c763d: [lib] Fix an invalid condition

Summary

We should check the accessToken instead of checking userID twice.

Depends on D12749

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jul 16 2024, 6:14 AM

Herald added a subscriber: ashoat. · View Herald TranscriptJul 16 2024, 6:14 AM

Harbormaster completed remote builds in B30383: Diff 42346.Jul 16 2024, 6:31 AM

tomek requested review of this revision.Jul 16 2024, 6:31 AM

tomek added a child revision: D12776: [lib] Generate P2P messages based on actions.Jul 16 2024, 7:24 AM

🤦‍♂️🙄
Thanks for fixing

This revision is now accepted and ready to land.Jul 18 2024, 6:44 AM

tomek edited parent revisions, added: D12747: [lib] Enable automatic retries for some messages; removed: D12749: [lib] Stop requiring sequential messages.Jul 18 2024, 7:10 AM

Closed by commit rCOMM5eba6c1c763d: [lib] Fix an invalid condition (authored by tomek). · Explain WhyJul 19 2024, 7:47 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM5eba6c1c763d: [lib] Fix an invalid condition.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

peer-to-peer-context.js

6 lines

Diff 42544

View Options

lib/tunnelbroker/peer-to-peer-context.js

[lib] Fix an invalid conditionClosedPublicActions