Page MenuHomePhabricator
Differential D12623

[identity] downgrade no auth message error to warning
ClosedPublic
Actions

Authored by will on Jun 28 2024, 4:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 11:50 PM
Unknown Object (File)
Mon, Nov 25, 11:28 PM
Unknown Object (File)
Sun, Nov 24, 5:50 PM
Unknown Object (File)
Sun, Nov 24, 2:17 PM
Unknown Object (File)
Wed, Nov 20, 9:50 PM
Unknown Object (File)
Wed, Nov 20, 9:50 PM
Unknown Object (File)
Mon, Nov 11, 12:56 PM
Unknown Object (File)
Oct 22 2024, 1:16 PM
View All 70 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM200062e6eea2: [identity] downgrade no auth message error to warning
Summary

I don't think this needs to be an error. This was triggered recently and might've been a websocket health check or something related.

Test Plan

cargo build

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Jun 28 2024, 4:25 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 28 2024, 4:25 PM
Harbormaster completed remote builds in B30014: Diff 41830.Jun 28 2024, 4:41 PM
will requested review of this revision.Jun 28 2024, 4:41 PM
bartek accepted this revision.Jul 1 2024, 2:36 AM
This revision is now accepted and ready to land.Jul 1 2024, 2:36 AM
bartek added a comment.Jul 1 2024, 2:38 AM

This was triggered recently and might've been a websocket health check or something related.

It's worth checking if clients aren't broken and they do send the message

will added a comment.Jul 25 2024, 2:18 PM
In D12623#357165, @bartek wrote:

This was triggered recently and might've been a websocket health check or something related.

It's worth checking if clients aren't broken and they do send the message

Was able to test this before when running identity search on a debug iOS client. Don't believe clients are broken.

will updated this revision to Diff 42785.Jul 25 2024, 2:19 PM

rebase

Harbormaster completed remote builds in B30679: Diff 42785.Jul 25 2024, 2:36 PM
Closed by commit rCOMM200062e6eea2: [identity] downgrade no auth message error to warning (authored by will). · Explain WhyJul 25 2024, 2:38 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM200062e6eea2: [identity] downgrade no auth message error to warning.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
websockets/
5 lines

Diff 42790

View Options

services/identity/src/websockets/mod.rs

Loading...