Page MenuHomePhabricator
Differential D12948

[lib] Add a function to DM operations spec checking if an operation can be applied
ClosedPublic
Actions

Authored by tomek on Jul 30 2024, 9:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 5:32 PM
Unknown Object (File)
Sun, Mar 23, 1:02 PM
Unknown Object (File)
Mon, Mar 17, 11:17 AM
Unknown Object (File)
Mar 3 2025, 3:46 PM
Unknown Object (File)
Feb 26 2025, 6:08 AM
Unknown Object (File)
Feb 25 2025, 3:16 PM
Unknown Object (File)
Feb 18 2025, 3:56 AM
Unknown Object (File)
Feb 18 2025, 3:56 AM
View All Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
ashoat
Commits
rCOMM8237d225adce: [lib] Add a function to DM operations spec checking if an operation can be…
Summary

If this function returns false, we will queue the operation for later. Some logic in the processing code can be simplified as the result of this change.

https://linear.app/comm/issue/ENG-8909/modify-operations-specs-so-that-they-can-report-that-an-operation-cant

Depends on D12936

Test Plan

Tested this for one case - creating change_thread_settings update for a thread that isn't present in the store. Also tested that if the thread is in the store, the ops are being processed.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jul 30 2024, 9:15 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJul 30 2024, 9:15 AM
Harbormaster completed remote builds in B30819: Diff 42972.Jul 30 2024, 9:32 AM
tomek requested review of this revision.Jul 30 2024, 9:32 AM
tomek updated this revision to Diff 42973.Jul 30 2024, 9:39 AM

Change the API

tomek added a child revision: D12949: [lib] Create a new action and a reducer that queue the operations.Jul 30 2024, 9:53 AM
Harbormaster completed remote builds in B30820: Diff 42973.Jul 30 2024, 9:56 AM
ashoat added a comment.Jul 30 2024, 10:45 PM

I had previously suggested implemented a solution to this based on a tcomb validator. We'll need to specify IDs that have to be checked for collision again certain SQLite tables, and I was planning on using a tcomb validator approach for that. It seems like checking IDs for existence in certain SQLite tables is a very similar problem, and ought to be solved in a similar way.

inka accepted this revision.Jul 31 2024, 3:00 AM

This is great!

This revision is now accepted and ready to land.Jul 31 2024, 3:00 AM
inka added a comment.Jul 31 2024, 3:03 AM

Not sure if @ashoat's comment demands changes to this diff, please make sure to address it

tomek added a comment.Jul 31 2024, 10:10 AM
In D12948#366063, @ashoat wrote:

I had previously suggested implemented a solution to this based on a tcomb validator. We'll need to specify IDs that have to be checked for collision again certain SQLite tables, and I was planning on using a tcomb validator approach for that. It seems like checking IDs for existence in certain SQLite tables is a very similar problem, and ought to be solved in a similar way.

I'm not sure. It sounds similar, but there are important differences:

  1. If isProcessingPossible === false we don't say anything about the validity of the operation. We only know that it can't be processed now.
  2. Some specs will have a more complicated logic, e.g. add-members-spec. I'm not sure if it will be possible to express a thing like this in a validator.
  3. There are multiple possible results of canBeProcessed function - currently the only valid reason is that a thread is missing, but maybe in some new specs there will be more. Regardless, we would need a validator to return something more than just a valid / invalid status. I think we're doing some more complicated transformation with validators, e.g. while checking for the new user ID, so it can be done.

It feels to me that validation and checking if an operation can be processed are two distinct things and using validators instead of canBeProcessed will be more complicated. But I'm open to giving it a try. If we decide to do that I would rather land this diff and modify the logic later, to make sure we unblock other things (in this case the whole queueing logic).

ashoat accepted this revision.Aug 1 2024, 12:56 PM

Discussed this with @tomek in our 1:1 and we agreed to proceed with this approach for now.

I think that using validators for the most common cases makes sense, but I agree there are exceptions where we'll need to do something more complicated. For those complicated cases, I think having this canBeProcessed function on the spec makes sense

lib/types/dm-ops.js
288–291 ↗(On Diff #42973)

When I introduced this, it was intentionally not read-only. The idea is that the caller can do anything they want with the result

If there is a strong reason for making this read-only now, I would think we'd want $ReadOnlyArray instead of Array

But in that case, it's just ProcessDMOpsPayload, which is defined below

Can we revert this change?

tomek added inline comments.Aug 2 2024, 2:34 AM
lib/types/dm-ops.js
288–291 ↗(On Diff #42973)

The idea is that the caller can do anything they want with the result

I think that can be true for a lot of our types, except e.g. things returned from Redux and props. I'm not sure why we want to have a different approach here.

Can we revert this change?

Sure, I'll do that!

tomek updated this revision to Diff 43032.Aug 2 2024, 2:35 AM

Revert readonly

Harbormaster completed remote builds in B30865: Diff 43032.Aug 2 2024, 2:52 AM
tomek edited the test plan for this revision. (Show Details)Aug 2 2024, 4:53 AM
Closed by commit rCOMM8237d225adce: [lib] Add a function to DM operations spec checking if an operation can be… (authored by tomek). · Explain WhyAug 2 2024, 8:38 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM8237d225adce: [lib] Add a function to DM operations spec checking if an operation can be….
ashoat added a comment.Aug 2 2024, 8:57 AM

I think that can be true for a lot of our types, except e.g. things returned from Redux and props. I'm not sure why we want to have a different approach here.

I don't agree that this is a "different approach". I try to consistently use this approach, except in cases where the returned value really should not be modified.

Revision Contents
Changeset List

Diff 43032

View Options

lib/shared/dm-ops/add-members-spec.js

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

lib/shared/dm-ops/change-thread-settings-spec.js

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

lib/shared/dm-ops/create-sidebar-spec.js

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

lib/shared/dm-ops/create-thread-spec.js

Show All 25 Lines
import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js'; import { ChatMentionContextProvider } from 'lib/components/chat-mention-provider.react.js';
import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js'; import { EditUserAvatarProvider } from 'lib/components/edit-user-avatar-provider.react.js';
import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js'; import { ENSCacheProvider } from 'lib/components/ens-cache-provider.react.js';
import IntegrityHandler from 'lib/components/integrity-handler.react.js'; import IntegrityHandler from 'lib/components/integrity-handler.react.js';
import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js'; import KeyserverConnectionsHandler from 'lib/components/keyserver-connections-handler.js';
import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js'; import { MediaCacheProvider } from 'lib/components/media-cache-provider.react.js';
import PrekeysHandler from 'lib/components/prekeys-handler.react.js'; import PrekeysHandler from 'lib/components/prekeys-handler.react.js';
import { StaffContextProvider } from 'lib/components/staff-provider.react.js'; import { StaffContextProvider } from 'lib/components/staff-provider.react.js';
import { IdentitySearchProvider } from 'lib/identity-search/identity-search-context.js';
import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js'; import { CallKeyserverEndpointProvider } from 'lib/keyserver-conn/call-keyserver-endpoint-provider.react.js';
import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js'; import { TunnelbrokerProvider } from 'lib/tunnelbroker/tunnelbroker-context.js';
import { actionLogger } from 'lib/utils/action-logger.js'; import { actionLogger } from 'lib/utils/action-logger.js';
import { OlmSessionCreatorProvider } from './account/account-hooks.js'; import { OlmSessionCreatorProvider } from './account/account-hooks.js';
import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js'; import { RegistrationContextProvider } from './account/registration/registration-context-provider.react.js';
import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js'; import NativeEditThreadAvatarProvider from './avatars/native-edit-thread-avatar-provider.react.js';
import BackupHandler from './backup/backup-handler.js'; import BackupHandler from './backup/backup-handler.js';
▲ Show 20 Lines • Show All 257 Lines • ▼ Show 20 Lines if (initialState) {
); );
} }
return ( return (
<GestureHandlerRootView style={styles.app}> <GestureHandlerRootView style={styles.app}>
<StaffContextProvider> <StaffContextProvider>
<IdentityServiceContextProvider> <IdentityServiceContextProvider>
<OlmSessionCreatorProvider> <OlmSessionCreatorProvider>
<TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}> <TunnelbrokerProvider initMessage={tunnelbrokerInitMessage}>
<IdentitySearchProvider>
<FeatureFlagsProvider> <FeatureFlagsProvider>
<NavContext.Provider value={navContext}> <NavContext.Provider value={navContext}>
<RootContext.Provider value={rootContext}> <RootContext.Provider value={rootContext}>
<InputStateContainer> <InputStateContainer>
<MessageEditingContextProvider> <MessageEditingContextProvider>
<SafeAreaProvider initialMetrics={initialWindowMetrics}> <SafeAreaProvider
initialMetrics={initialWindowMetrics}
>
<ActionSheetProvider> <ActionSheetProvider>
<ENSCacheProvider provider={provider}> <ENSCacheProvider provider={provider}>
<MediaCacheProvider <MediaCacheProvider
persistence={filesystemMediaCache} persistence={filesystemMediaCache}
> >
<EditUserAvatarProvider> <EditUserAvatarProvider>
<NativeEditThreadAvatarProvider> <NativeEditThreadAvatarProvider>
<MarkdownContextProvider> <MarkdownContextProvider>
<MessageSearchProvider> <MessageSearchProvider>
<BottomSheetProvider> <BottomSheetProvider>
<RegistrationContextProvider> <RegistrationContextProvider>
<SQLiteDataHandler /> <SQLiteDataHandler />
<ConnectedStatusBar /> <ConnectedStatusBar />
<ReduxPersistGate <ReduxPersistGate
persistor={getPersistor()} persistor={getPersistor()}
> >
{gated} {gated}
</ReduxPersistGate> </ReduxPersistGate>
<PersistedStateGate> <PersistedStateGate>
<KeyserverConnectionsHandler <KeyserverConnectionsHandler
socketComponent={Socket} socketComponent={Socket}
detectUnsupervisedBackgroundRef={ detectUnsupervisedBackgroundRef={
detectUnsupervisedBackgroundRef detectUnsupervisedBackgroundRef
} }
/> />
<VersionSupportedChecker /> <VersionSupportedChecker />
<PrekeysHandler /> <PrekeysHandler />
</PersistedStateGate> </PersistedStateGate>
{navigation} {navigation}
</RegistrationContextProvider> </RegistrationContextProvider>
</BottomSheetProvider> </BottomSheetProvider>
</MessageSearchProvider> </MessageSearchProvider>
</MarkdownContextProvider> </MarkdownContextProvider>
</NativeEditThreadAvatarProvider> </NativeEditThreadAvatarProvider>
</EditUserAvatarProvider> </EditUserAvatarProvider>
</MediaCacheProvider> </MediaCacheProvider>
</ENSCacheProvider> </ENSCacheProvider>
</ActionSheetProvider> </ActionSheetProvider>
</SafeAreaProvider> </SafeAreaProvider>
</MessageEditingContextProvider> </MessageEditingContextProvider>
</InputStateContainer> </InputStateContainer>
</RootContext.Provider> </RootContext.Provider>
</NavContext.Provider> </NavContext.Provider>
</FeatureFlagsProvider> </FeatureFlagsProvider>
</IdentitySearchProvider>
</TunnelbrokerProvider> </TunnelbrokerProvider>
</OlmSessionCreatorProvider> </OlmSessionCreatorProvider>
</IdentityServiceContextProvider> </IdentityServiceContextProvider>
</StaffContextProvider> </StaffContextProvider>
</GestureHandlerRootView> </GestureHandlerRootView>
); );
} }
Show All 19 Lines
View Options

lib/shared/dm-ops/dm-op-spec.js

Loading...
View Options

lib/shared/dm-ops/join-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/leave-thread-spec.js

Loading...
View Options

lib/shared/dm-ops/process-dm-ops.js

Loading...
View Options

lib/shared/dm-ops/remove-members-spec.js

Loading...
View Options

lib/shared/dm-ops/send-edit-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-reaction-message-spec.js

Loading...
View Options

lib/shared/dm-ops/send-text-message-spec.js

Loading...