Page MenuHomePhabricator
Differential D12971

[backup] Add endpoint to delete user data
ClosedPublic
Actions

Authored by bartek on Aug 5 2024, 4:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 1:18 PM
Unknown Object (File)
Wed, Nov 6, 11:03 PM
Unknown Object (File)
Wed, Nov 6, 11:03 PM
Unknown Object (File)
Wed, Nov 6, 11:02 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
Unknown Object (File)
Oct 6 2024, 7:14 PM
Unknown Object (File)
Oct 6 2024, 7:14 PM
Unknown Object (File)
Oct 6 2024, 7:13 PM
View All 39 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
marcin
varun
Commits
rCOMM9fc405d0fda4: [backup] Add endpoint to delete user data
Summary

Added a DELETE /user_data/{user_id} Backup service endpoint that takes care of deleting all service user data.

Depends on D12970

Test Plan

Created two backups for user, and some logs (used Commtest to generate data). Called the endpoint in Postman

  • Verified that DDB data was deleted
  • Verified that blobs were removed from Blob service
  • Verified that only service-to-service token is accepted. HTTP 403 otherwise

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Aug 5 2024, 4:49 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 5 2024, 4:49 AM
bartek added a child revision: D12972: [identity] Add config for Backup service URL.Aug 5 2024, 4:51 AM
bartek published this revision for review.Aug 5 2024, 5:08 AM
kamil accepted this revision.Aug 5 2024, 5:53 AM
kamil added inline comments.
services/backup/src/http/handlers/user_data.rs
30 ↗(On Diff #43088)

I would log userID here

This revision is now accepted and ready to land.Aug 5 2024, 5:53 AM
bartek added inline comments.Aug 5 2024, 5:56 AM
services/backup/src/http/handlers/user_data.rs
30 ↗(On Diff #43088)

We consider userID as sensitive data in logs

This revision was landed with ongoing or failed builds.Aug 5 2024, 6:27 AM
Closed by commit rCOMM9fc405d0fda4: [backup] Add endpoint to delete user data (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM9fc405d0fda4: [backup] Add endpoint to delete user data.
Harbormaster completed remote builds in B30908: Diff 43088.Aug 5 2024, 6:48 AM

Revision Contents
Changeset List

PathSize
services/
backup/
src/
database/
18 lines
http/
handlers/
38 lines
9 lines

Diff 43124

View Options

services/backup/src/database/mod.rs

Loading...
View Options

services/backup/src/http/handlers/user_data.rs

Loading...
View Options

services/backup/src/http/mod.rs

Loading...