Page MenuHomePhabricator
Differential D12973

[identity] Delete Backup user data on account deletion
ClosedPublic
Actions

Authored by bartek on Aug 5 2024, 4:54 AM.
Tags
None
Referenced Files
F3204811: D12973.id43095.diff
Sat, Nov 9, 9:59 PM
F3204770: D12973.id43090.diff
Sat, Nov 9, 9:52 PM
F3203191: D12973.diff
Sat, Nov 9, 7:25 PM
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Wed, Nov 6, 10:49 PM
Unknown Object (File)
Wed, Nov 6, 10:19 PM
View All 63 Files
Subscribers
ashoat
tomek

Details

Reviewers
will
varun
kamil
Commits
rCOMM7d827184c069: [identity] Delete Backup user data on account deletion
Summary

Similarly to how we call Tunnelbroker, called Backup Service DELETE /user_data endpoint from D12970 to delete backup data
in DeleteUser RPCs.

Depends on D12972

Test Plan

Called the DeleteWalletUser RPC. Verified that Backup is called and user data is actually deleted from Backup DDB

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Aug 5 2024, 4:54 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 5 2024, 4:54 AM
bartek updated this revision to Diff 43095.Aug 5 2024, 5:25 AM

Improve service-to-service token handling

bartek published this revision for review.Aug 5 2024, 5:35 AM
bartek added inline comments.
services/identity/src/main.rs
88–89 ↗(On Diff #43095)

The second argument is identity service URL, but in fact, we're never going to need it, so I think it can stay hardcoded

kamil accepted this revision.Aug 5 2024, 6:10 AM
This revision is now accepted and ready to land.Aug 5 2024, 6:10 AM
This revision was landed with ongoing or failed builds.Aug 5 2024, 6:28 AM
Closed by commit rCOMM7d827184c069: [identity] Delete Backup user data on account deletion (authored by bartek). · Explain Why
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM7d827184c069: [identity] Delete Backup user data on account deletion.
Harbormaster failed remote builds in B30915: Diff 43095!Aug 5 2024, 6:45 AM
Harbormaster failed remote builds in B30910: Diff 43090!

Revision Contents
Changeset List

PathSize
services/
identity/
src/
41 lines
2 lines
grpc_services/
17 lines
6 lines

Diff 43126

View Options

services/identity/src/backup.rs

Loading...
View Options

services/identity/src/error.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

services/identity/src/main.rs

Loading...