[tunnelbroker] invalidate bad wns device tokens
ClosedPublic
Actions

Authored by varun on Aug 7 2024, 3:15 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMM3f814c0b29f7: [tunnelbroker] invalidate bad wns device tokens

Summary

based on keyserver error codes

see wns response codes here

Test Plan

Manually malform device token for windows device in DDB (url), try sending notif to this device and verify that flag was flipped

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Aug 7 2024, 3:15 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 7 2024, 3:15 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 7 2024, 3:34 PM

Harbormaster failed remote builds in B30995: Diff 43241!

varun requested review of this revision.Aug 7 2024, 3:45 PM

varun added a child revision: D13022: [tunnelbroker] disallow windows device tokens that don't contain the correct domain.Aug 7 2024, 4:09 PM

varun edited the test plan for this revision. (Show Details)Aug 7 2024, 11:29 PM

Thanks!

This revision is now accepted and ready to land.Aug 8 2024, 1:03 AM

bartek accepted this revision.Aug 8 2024, 1:24 AM

This revision was landed with ongoing or failed builds.Aug 8 2024, 5:59 PM

Closed by commit rCOMM3f814c0b29f7: [tunnelbroker] invalidate bad wns device tokens (authored by varun). · Explain Why

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM3f814c0b29f7: [tunnelbroker] invalidate bad wns device tokens.

Revision Contents
Changeset List

Path

Size

services/

tunnelbroker/

src/

notifs/

wns/

mod.rs

4 lines

websockets/

session.rs

20 lines

Diff 43241

View Options

services/tunnelbroker/src/notifs/wns/mod.rs