Differential D13032

[lib] resend messages after race condition
ClosedPublic
Actions

Authored by kamil on Aug 8 2024, 5:27 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 29, 10:44 AM

	Unknown Object (File)
	Fri, Nov 29, 9:42 AM

	Unknown Object (File)
	Mon, Nov 25, 7:43 PM

	Unknown Object (File)
	Wed, Nov 20, 3:10 AM

	Unknown Object (File)
	Wed, Nov 20, 3:10 AM

	Unknown Object (File)
	Wed, Nov 20, 3:09 AM

	Unknown Object (File)
	Wed, Nov 20, 2:44 AM

	Unknown Object (File)
	Sat, Nov 9, 10:05 AM

View All 45 Files

Subscribers

Details

Reviewers

Commits

rCOMM345064750f40: [lib] resend messages after race condition

Summary

Depends on D13031

Test Plan

Create a session between devices A and B
On B comment out sending confirmation.
Send some messages from A to B
From B to A send a session request with the same session counter to trigger resolving the race condition
Test that all messages are sent again and decrypted successfully

Diff Detail

Repository

Branch

resending-2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Aug 8 2024, 5:27 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptAug 8 2024, 5:27 AM

kamil mentioned this in D13029: [web] introduce resetting Outbound P2P Messages to shared worker.Aug 8 2024, 5:30 AM

kamil mentioned this in D13030: [native] introduce resetting Outbound P2P Messages to `CommCoreModule`.

kamil mentioned this in D13031: [lib] introduce resetting Outbound P2P Messages to `SQLiteAPI`.

kamil published this revision for review.Aug 8 2024, 5:48 AM

kamil edited the test plan for this revision. (Show Details)

kamil added inline comments.

lib/tunnelbroker/use-resend-peer-to-peer-messages.js
16

Harbormaster failed remote builds in B31011: Diff 43260!Aug 8 2024, 5:50 AM

kamil added a child revision: D13033: [lib] add session version to EncryptedData.Aug 8 2024, 8:50 AM

tomek accepted this revision.Aug 12 2024, 1:21 AM

This revision is now accepted and ready to land.Aug 12 2024, 1:21 AM

kamil mentioned this in rCOMM4ca3b99e9d25: [web] introduce resetting Outbound P2P Messages to shared worker.Aug 13 2024, 4:10 AM

kamil mentioned this in rCOMM12da08a568d6: [native] introduce resetting Outbound P2P Messages to `CommCoreModule`.

kamil mentioned this in rCOMMd5e299a6a2fb: [lib] introduce resetting Outbound P2P Messages to `SQLiteAPI`.

kamil added a child revision: D13056: [lib] resend messages after session creation request.Aug 13 2024, 4:49 AM

This revision was landed with ongoing or failed builds.Aug 21 2024, 2:57 AM

Closed by commit rCOMM345064750f40: [lib] resend messages after race condition (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM345064750f40: [lib] resend messages after race condition.

Revision Contents
Changeset List

Path

Size

lib/

tunnelbroker/

use-peer-to-peer-message-handler.js

6 lines

use-resend-peer-to-peer-messages.js

22 lines

Diff 43260

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...

lib/tunnelbroker/use-resend-peer-to-peer-messages.js

Loading...