Page MenuHomePhabricator
Differential D13035

[lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs
ClosedPublic
Actions

Authored by varun on Aug 9 2024, 11:32 AM.
Tags
None
Referenced Files
F3354183: D13035.diff
Sat, Nov 23, 12:13 PM
F3353098: D13035.id43577.diff
Sat, Nov 23, 8:12 AM
Unknown Object (File)
Thu, Nov 21, 1:12 PM
Unknown Object (File)
Wed, Nov 13, 12:57 PM
Unknown Object (File)
Wed, Nov 13, 12:57 PM
Unknown Object (File)
Oct 22 2024, 10:44 AM
Unknown Object (File)
Oct 22 2024, 10:19 AM
Unknown Object (File)
Oct 22 2024, 10:19 AM
View All 40 Files
Subscribers
tomek

Details

Reviewers
ashoat
Commits
rCOMM4679fd50c9c8: [lib] rename getForeignPeerDevices -> getForeignPeerDeviceIDs
Summary

we only return the device IDs from this function, so renaming to make that more clear

Addressing feedback left in D12809

Depends on D12809

Test Plan

rename, so just ran flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
actions/
4 lines
selectors/
36 lines
tunnelbroker/
4 lines
native/
profile/
4 lines

Diff 43274

View Options

lib/actions/user-actions.js

Loading...
View Options

lib/selectors/user-selectors.js

Loading...
View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...
View Options

native/profile/secondary-device-qr-code-scanner.react.js

Loading...