This differential implements new endpoint on the keyserver that creates new notifs olm session on client demand.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- marcin/eng-9025
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
Worth considering potential race conditions with this endpoint and INITIAL_NOTIFICATIONS_ENCRYPTED_MESSAGE to avoid diverged session (keyserver and client session are different),
| keyserver/src/endpoints.js | ||
|---|---|---|
| 495 | I think the validator should be named recreateNotifsOlmSessionInputValidator to match convention and placed in file with responder | |
| lib/actions/keyserver-actions.js | ||
| 11 | I would put this in user-actions.js along with getOlmSessionInitializationData | |
| 15–18 | I would create a read-only type RecreateNotifsOlmSessionInput and use it instead of spreading in two places | |