Page MenuHomePhabricator
Differential D13046

[lib] reset session and resend message when device is unable to decrypt messages
ClosedPublic
Actions

Authored by kamil on Aug 12 2024, 2:49 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 22, 11:08 PM
Unknown Object (File)
Fri, Nov 22, 11:01 PM
Unknown Object (File)
Fri, Nov 22, 6:53 PM
Unknown Object (File)
Wed, Nov 20, 3:09 AM
Unknown Object (File)
Wed, Nov 20, 2:44 AM
Unknown Object (File)
Sat, Nov 9, 9:52 AM
Unknown Object (File)
Sat, Nov 9, 9:52 AM
Unknown Object (File)
Thu, Nov 7, 5:13 AM
View All 53 Files
Subscribers
ashoat

Details

Reviewers
tomek
marcin
Commits
rCOMM575677018ac0: [lib] reset session and resend message when device is unable to decrypt messages
Summary

ENG-6982.

We want to reset session when there was an error while decrypting.

Depends on D13033

Test Plan
  1. Create a session between devices A and B
  2. On B comment out sending confirmation.
  3. Send some messages from A to B
  4. On B simulate Olm error.
  5. Test that all messages are sent again and decrypted successfully.

Diff Detail

Repository
rCOMM Comm
Branch
land
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Aug 12 2024, 2:49 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptAug 12 2024, 2:49 AM
kamil published this revision for review.Aug 12 2024, 3:04 AM
kamil added inline comments.
lib/utils/olm-utils.js
126–129 ↗(On Diff #43304)

We no longer track order and not using sequential decrypt

Harbormaster failed remote builds in B31040: Diff 43304!Aug 12 2024, 3:07 AM
kamil added a child revision: D13047: [SQLite] recreate table for Inbound P2P messages.Aug 12 2024, 6:43 AM
tomek accepted this revision.Aug 19 2024, 5:46 AM
tomek added inline comments.
lib/utils/olm-utils.js
123 ↗(On Diff #43304)
This revision is now accepted and ready to land.Aug 19 2024, 5:46 AM
kamil updated this revision to Diff 43498.Aug 20 2024, 3:53 AM

address review

Harbormaster completed remote builds in B31168: Diff 43498.Aug 20 2024, 4:10 AM
Closed by commit rCOMM575677018ac0: [lib] reset session and resend message when device is unable to decrypt messages (authored by kamil). · Explain WhyAug 21 2024, 2:57 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM575677018ac0: [lib] reset session and resend message when device is unable to decrypt messages.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
36 lines
utils/
9 lines

Diff 43498

View Options

lib/tunnelbroker/use-peer-to-peer-message-handler.js

Loading...
View Options

lib/utils/olm-utils.js

Loading...