In getInitialMessages we have to explicitly specify the selected columns, and it doesn't make sense to include there fields that are skipped by processMessagesResults, so I modified the processMessagesResults function and all the places where it is used to skip the unused columns.

I wonder if it would be better to put this in a place where the web code could eventually access it. But not very important

It appears that it's critical for this to be synced with JS code

You don't appear to have added comments on both sides, which is the absolute minimum we need when we are doing something like this (expected two pieces of code to be synced)

Probably a better solution would be to have a collection in some place like ThreadTypeEnum.h... keeping SQL logic in sync with a list seems cumbersome

Probably need comments to keep this list in sync as well

Makes sense. Going to introduce a list to that file.

About sharing code with JS - going to add the comments. In the future, we can do https://linear.app/comm/issue/ENG-8995/shared-constant-between-web-and-native which will solve the issue completely.

It is already indirectly used by the web. SQLiteQueryExecutor can import from this file and use it through the WASM. The fact that it is placed inside native is unfortunate - we have a task https://linear.app/comm/issue/ENG-4311/move-database-code-to-shared that covers moving the whole shared code.

Yeah, good call.