Page MenuHomePhabricator
Differential D13142

[web] Expose messages fetching function through the worker and sqlite-api
ClosedPublic
Actions

Authored by tomek on Aug 22 2024, 10:48 AM.
Tags
None
Referenced Files
F2842353: D13142.diff
Sun, Sep 29, 1:29 PM
F2838711: D13142.id43692.diff
Sat, Sep 28, 11:15 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Wed, Sep 25, 3:44 PM
Unknown Object (File)
Sun, Sep 22, 1:09 PM
View All 39 Files
Subscribers
ashoat

Details

Reviewers
kamil
inka
Commits
rCOMMe8389432b37e: [web] Expose messages fetching function through the worker and sqlite-api
Summary

We also need to call this function on web.

https://linear.app/comm/issue/ENG-8701/create-c-functions-that-fetch-a-subset-of-messages

Depends on D13141

Test Plan

Tested this later in the stack by checking if fetching messages from the DB works on the web, in thick threads with a lot of messages.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Aug 22 2024, 10:48 AM
Herald added a subscriber: ashoat. · View Herald TranscriptAug 22 2024, 10:48 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Aug 22 2024, 11:08 AM
Harbormaster failed remote builds in B31222: Diff 43593!
tomek updated this revision to Diff 43599.Aug 23 2024, 3:55 AM

Rebase

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 23 2024, 4:00 AM
Harbormaster failed remote builds in B31226: Diff 43599!
Harbormaster completed remote builds in B31226: Diff 43599.Aug 23 2024, 4:11 AM
tomek requested review of this revision.Aug 23 2024, 4:11 AM
tomek added a child revision: D13147: [web][native] Extract common fetching logic.Aug 23 2024, 5:03 AM
kamil accepted this revision.Aug 26 2024, 2:54 AM

Please update the test plan, accepting it because it looks like it was tested later in the stack

This revision is now accepted and ready to land.Aug 26 2024, 2:54 AM
tomek edited the test plan for this revision. (Show Details)Aug 27 2024, 4:49 AM
Closed by commit rCOMMe8389432b37e: [web] Expose messages fetching function through the worker and sqlite-api (authored by tomek). · Explain WhyAug 27 2024, 8:02 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMe8389432b37e: [web] Expose messages fetching function through the worker and sqlite-api.

Revision Contents
Changeset List

PathSize
lib/
types/
5 lines
utils/
__mocks__/
1 line
native/
database/
1 line
web/
database/
17 lines
shared-worker/
worker/
10 lines
types/
11 lines

Diff 43690

View Options

lib/types/sqlite-types.js

Loading...
View Options

lib/utils/__mocks__/config.js

Loading...
View Options

native/database/sqlite-api.js

Loading...
View Options

web/database/sqlite-api.js

Loading...
View Options

web/shared-worker/worker/shared-worker.js

Loading...
View Options

web/types/worker-types.js

Loading...