Page MenuHomePhabricator
Differential D13286

[web] Support setting image avatars for thick threads
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 1:41 AM.
Tags
None
Referenced Files
F3367988: D13286.diff
Mon, Nov 25, 5:40 PM
Unknown Object (File)
Fri, Nov 22, 4:07 PM
Unknown Object (File)
Fri, Nov 22, 4:07 PM
Unknown Object (File)
Tue, Nov 12, 6:32 AM
Unknown Object (File)
Tue, Nov 12, 5:56 AM
Unknown Object (File)
Mon, Nov 11, 11:47 PM
Unknown Object (File)
Oct 22 2024, 5:34 AM
Unknown Object (File)
Oct 22 2024, 5:33 AM
View All 37 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
tomek
Commits
rCOMMb2ed03b83d45: [web] Support setting image avatars for thick threads
Summary

Updated avatar upload hook on web to make keyserver upload optional. Disabled upload for thick threads. Forced Blob uploads for non-keyserver uploads, regardless of the flag.
This follows chagnes from D13280.

Depends on D13280, D13285

Test Plan
  • Successfully set image avatar for DM thread, with keyserver killed.
  • Keyserver avatars work as before

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

bartek created this revision.Sep 11 2024, 1:41 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 11 2024, 1:41 AM
Harbormaster completed remote builds in B31524: Diff 44028.Sep 11 2024, 1:58 AM
bartek published this revision for review.Sep 11 2024, 2:08 AM
bartek edited the test plan for this revision. (Show Details)
bartek added a reviewer: tomek.
tomek accepted this revision.Sep 11 2024, 2:45 AM
This revision is now accepted and ready to land.Sep 11 2024, 2:45 AM
bartek added a child revision: D13294: [native] Update avatar hooks to support skipping keyserver upload.Sep 11 2024, 10:57 AM
ashoat added inline comments.Sep 11 2024, 12:13 PM
web/avatars/avatar-hooks.react.js
21

Read-only types unless we need them to be writable

bartek updated this revision to Diff 44148.Sep 13 2024, 4:22 AM

Rebase, make type readonly

Harbormaster completed remote builds in B31603: Diff 44148.Sep 13 2024, 4:46 AM
Closed by commit rCOMMb2ed03b83d45: [web] Support setting image avatars for thick threads (authored by bartek). · Explain WhySep 13 2024, 5:45 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMMb2ed03b83d45: [web] Support setting image avatars for thick threads.

Revision Contents
Changeset List

Diff 44028

View Options

web/avatars/avatar-hooks.react.js

Loading...
View Options

web/avatars/edit-thread-avatar-menu.react.js

Loading...