Differential D13281

[web][native] Enable blob uploads for thick threads in input-state-container
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 1:23 AM.

Details

Reviewers

kamil

Commits

rCOMMaba560e4bce3: [web][native] Enable blob uploads for thick threads in input-state-container

Summary

Part of ENG-8708.

Updated media upload logic in both input-state-containers to:

Always use Blob service for thick threads (regardless of the hardcoded flag)
Don't upload metadata to keyserver in thick threads.

Depends on D13280

Test Plan

Encrypted multimedia work as before for keyserver uploads
TBD for thick threads

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Sep 11 2024, 1:23 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 11 2024, 1:23 AM

bartek added a child revision: D13282: [web] Avoid keyserver call when deleting media for DMs.Sep 11 2024, 1:27 AM

Harbormaster failed remote builds in B31519: Diff 44023!Sep 11 2024, 1:37 AM

Fix flow

bartek edited the test plan for this revision. (Show Details)Sep 11 2024, 2:26 AM

Harbormaster completed remote builds in B31525: Diff 44030.Sep 11 2024, 2:33 AM

bartek published this revision for review.Sep 11 2024, 2:38 AM

kamil accepted this revision.Sep 12 2024, 3:50 AM

This revision is now accepted and ready to land.Sep 12 2024, 3:50 AM

Closed by commit rCOMMaba560e4bce3: [web][native] Enable blob uploads for thick threads in input-state-container (authored by bartek). · Explain WhySep 13 2024, 5:45 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMaba560e4bce3: [web][native] Enable blob uploads for thick threads in input-state-container.

Revision Contents
Changeset List

Path

Size

native/

input/

input-state-container.react.js

17 lines

web/

input/

input-state-container.react.js

22 lines

Diff 44161

View Options

native/input/input-state-container.react.js