Page MenuHomePhabricator

[lib] Add type for thick thread avatar update request
ClosedPublic

Authored by bartek on Sep 11 2024, 1:32 AM.
Tags
None
Referenced Files
F4080651: D13284.id44026.diff
Sat, Feb 15, 9:30 PM
F4080604: D13284.id.diff
Sat, Feb 15, 9:29 PM
Unknown Object (File)
Sat, Feb 1, 10:14 AM
Unknown Object (File)
Sat, Feb 1, 12:22 AM
Unknown Object (File)
Thu, Jan 30, 2:52 PM
Unknown Object (File)
Jan 15 2025, 6:16 AM
Unknown Object (File)
Dec 27 2024, 1:43 AM
Unknown Object (File)
Dec 27 2024, 1:43 AM
Subscribers

Details

Summary

Some details in this Linear comment.

The "avatar update request" requires another, keyserver-agnostic type for encrypted images. The type can be used for setting image avatars for DM threads.

Test Plan

Flow, eslint. Used later in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 11 2024, 2:05 AM
bartek added reviewers: tomek, inka.
bartek added inline comments.
lib/types/avatar-types.js
47 ↗(On Diff #44026)

I cannot think of a good name for this.
Theoretically, this type can be reused later for user avatars when we start syncing them without keyserver, so thick_thread_image is too narrow, should be something keyserverless and general

tomek added inline comments.
lib/types/avatar-types.js
47 ↗(On Diff #44026)

Maybe non_keyserver_image?

This revision is now accepted and ready to land.Sep 11 2024, 2:41 AM