Page MenuHomePhabricator
Differential D13297

[native] Skip keyserver upload for thick thread avatars
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 11:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 8, 3:04 AM
Unknown Object (File)
Mon, Mar 3, 11:41 PM
Unknown Object (File)
Sat, Mar 1, 10:58 AM
Unknown Object (File)
Wed, Feb 26, 11:35 AM
Unknown Object (File)
Feb 15 2025, 9:30 PM
Unknown Object (File)
Feb 15 2025, 9:29 PM
Unknown Object (File)
Feb 1 2025, 10:14 AM
Unknown Object (File)
Feb 1 2025, 10:14 AM
View All 68 Files
Subscribers
ashoat

Details

Reviewers
kamil
tomek
Commits
rCOMM0192849034c2: [native] Skip keyserver upload for thick thread avatars
Summary

Updated avatar-hooks for thread avatars to accept threadInfo instead of threadID and set shouldUploadMetadataToKeyserver based on threadTypeIsThick()

Depends on D13294, D13296

Test Plan

Successfully set thick thread avatar on native with keyserver killed

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 44169

View Options

native/avatars/avatar-hooks.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

native/avatars/edit-thread-avatar.react.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines
View Options

native/media/thread-avatar-camera-modal.react.js

// @flow // @flow
import t from 'tcomb'; import t from 'tcomb';
import type { UpdateSpec } from './update-spec.js'; import type { UpdateSpec } from './update-spec.js';
import type { RawThreadInfos } from '../../types/thread-types.js'; import type { MixedRawThreadInfos } from '../../types/thread-types.js';
import { updateTypes } from '../../types/update-types-enum.js'; import { updateTypes } from '../../types/update-types-enum.js';
import type { import type {
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
} from '../../types/update-types.js'; } from '../../types/update-types.js';
import { tID, tNumber, tShape } from '../../utils/validation-utils.js'; import { tID, tNumber, tShape } from '../../utils/validation-utils.js';
export const deleteThreadSpec: UpdateSpec< export const deleteThreadSpec: UpdateSpec<
ThreadDeletionUpdateInfo, ThreadDeletionUpdateInfo,
ThreadDeletionRawUpdateInfo, ThreadDeletionRawUpdateInfo,
ThreadDeletionUpdateData, ThreadDeletionUpdateData,
> = Object.freeze({ > = Object.freeze({
generateOpsForThreadUpdates( generateOpsForThreadUpdates(
storeThreadInfos: RawThreadInfos, storeThreadInfos: MixedRawThreadInfos,
update: ThreadDeletionUpdateInfo, update: ThreadDeletionUpdateInfo,
) { ) {
if (storeThreadInfos[update.threadID]) { if (storeThreadInfos[update.threadID]) {
return [ return [
{ {
type: 'remove', type: 'remove',
payload: { payload: {
ids: [update.threadID], ids: [update.threadID],
▲ Show 20 Lines • Show All 59 Lines • Show Last 20 Lines