[native] Skip keyserver upload for thick thread avatars
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 6:01 PM.

Details

Reviewers

kamil
tomek

Commits

rCOMM0192849034c2: [native] Skip keyserver upload for thick thread avatars

Summary

Updated avatar-hooks for thread avatars to accept threadInfo instead of threadID and set shouldUploadMetadataToKeyserver based on threadTypeIsThick()

Depends on D13294, D13296

Test Plan

Successfully set thick thread avatar on native with keyserver killed

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 11 2024, 6:01 PM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 11 2024, 6:01 PM

Harbormaster completed remote builds in B31543: Diff 44052.Sep 11 2024, 6:18 PM

bartek published this revision for review.Sep 11 2024, 6:29 PM

bartek mentioned this in D13294: [native] Update avatar hooks to support skipping keyserver upload.

tomek accepted this revision.Sep 12 2024, 7:45 AM

This revision is now accepted and ready to land.Sep 12 2024, 7:45 AM

Rebase before landing

Harbormaster failed remote builds in B31606: Diff 44151!Sep 13 2024, 11:46 AM

Rebase

Harbormaster completed remote builds in B31608: Diff 44153.Sep 13 2024, 12:35 PM

Closed by commit rCOMM0192849034c2: [native] Skip keyserver upload for thick thread avatars. · Explain WhySep 13 2024, 12:46 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM0192849034c2: [native] Skip keyserver upload for thick thread avatars.

Revision Contents
Changeset List

Path

Size

native/

avatars/

avatar-hooks.js

22 lines

edit-thread-avatar.react.js

4 lines

media/

thread-avatar-camera-modal.react.js

4 lines

Diff 44151

View Options

native/avatars/avatar-hooks.js

View Options

native/avatars/edit-thread-avatar.react.js

View Options

native/media/thread-avatar-camera-modal.react.js

[native] Skip keyserver upload for thick thread avatarsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 44151

native/avatars/avatar-hooks.js

native/avatars/edit-thread-avatar.react.js

native/media/thread-avatar-camera-modal.react.js

[native] Skip keyserver upload for thick thread avatars
ClosedPublic
Actions

Revision Contents
Changeset List