Page MenuHomePhabricator
Differential D13281

[web][native] Enable blob uploads for thick threads in input-state-container
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 1:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 11, 2:40 PM
Unknown Object (File)
Wed, Mar 5, 2:54 PM
Unknown Object (File)
Wed, Mar 5, 1:22 AM
Unknown Object (File)
Tue, Mar 4, 12:38 AM
Unknown Object (File)
Sun, Mar 2, 2:50 PM
Unknown Object (File)
Feb 26 2025, 11:35 AM
Unknown Object (File)
Feb 23 2025, 10:46 PM
Unknown Object (File)
Feb 18 2025, 1:20 AM
View All 71 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
Commits
rCOMMaba560e4bce3: [web][native] Enable blob uploads for thick threads in input-state-container
Summary

Part of ENG-8708.

Updated media upload logic in both input-state-containers to:

  • Always use Blob service for thick threads (regardless of the hardcoded flag)
  • Don't upload metadata to keyserver in thick threads.

Depends on D13280

Test Plan
  • Encrypted multimedia work as before for keyserver uploads
  • TBD for thick threads

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
input/
17 lines
web/
input/
22 lines

Diff 44161

View Options

native/input/input-state-container.react.js

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines
View Options

web/input/input-state-container.react.js

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines
import { import {
fullStateSyncActionType, fullStateSyncActionType,
incrementalStateSyncActionType, incrementalStateSyncActionType,
} from '../types/socket-types.js'; } from '../types/socket-types.js';
import { threadPermissions } from '../types/thread-permission-types.js'; import { threadPermissions } from '../types/thread-permission-types.js';
import type { import type {
LegacyRawThreadInfo, LegacyRawThreadInfo,
MinimallyEncodedRawThreadInfos, MinimallyEncodedRawThreadInfos,
RawThreadInfos, MixedRawThreadInfos,
} from '../types/thread-types.js'; } from '../types/thread-types.js';
import { import {
type ClientUpdateInfo, type ClientUpdateInfo,
processUpdatesActionType, processUpdatesActionType,
} from '../types/update-types.js'; } from '../types/update-types.js';
import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js'; import { translateClientDBThreadMessageInfos } from '../utils/message-ops-utils.js';
const _mapValuesWithKeys = _mapValues.convert({ cap: false }); const _mapValuesWithKeys = _mapValues.convert({ cap: false });
Show All 35 Lines
type FreshMessageStoreResult = { type FreshMessageStoreResult = {
+messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>, +messageStoreOperations: $ReadOnlyArray<MessageStoreOperation>,
+messageStore: MessageStore, +messageStore: MessageStore,
}; };
function freshMessageStore( function freshMessageStore(
messageInfos: $ReadOnlyArray<RawMessageInfo>, messageInfos: $ReadOnlyArray<RawMessageInfo>,
truncationStatus: { [threadID: string]: MessageTruncationStatus }, truncationStatus: { [threadID: string]: MessageTruncationStatus },
currentAsOf: { +[keyserverID: string]: number }, currentAsOf: { +[keyserverID: string]: number },
threadInfos: RawThreadInfos, threadInfos: MixedRawThreadInfos,
): FreshMessageStoreResult { ): FreshMessageStoreResult {
const unshimmed = unshimMessageInfos(messageInfos); const unshimmed = unshimMessageInfos(messageInfos);
const orderedMessageInfos = sortMessageInfoList(unshimmed); const orderedMessageInfos = sortMessageInfoList(unshimmed);
const messages = _keyBy(messageID)(orderedMessageInfos); const messages = _keyBy(messageID)(orderedMessageInfos);
const messageStoreReplaceOperations = orderedMessageInfos.map( const messageStoreReplaceOperations = orderedMessageInfos.map(
messageInfo => ({ messageInfo => ({
type: 'replace', type: 'replace',
▲ Show 20 Lines • Show All 1,511 Lines • Show Last 20 Lines