Paths

Table of Contentst

Differential D13294

[native] Update avatar hooks to support skipping keyserver upload
ClosedPublic
Actions

Authored by bartek on Sep 11 2024, 10:57 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 22, 5:22 PM

	Unknown Object (File)
	Fri, Nov 22, 5:22 PM

	Unknown Object (File)
	Fri, Nov 22, 5:06 PM

	Unknown Object (File)
	Fri, Nov 22, 4:07 PM

	Unknown Object (File)
	Fri, Nov 22, 4:07 PM

	Unknown Object (File)
	Fri, Nov 22, 4:07 PM

	Unknown Object (File)
	Fri, Nov 22, 12:28 PM

	Unknown Object (File)
	Tue, Nov 12, 5:32 PM

View All 64 Files

Subscribers

Details

Reviewers

kamil
tomek

Commits

rCOMMdf0080acb36e: [native] Update avatar hooks to support skipping keyserver upload

Summary

Update avatar-hooks for uploading media to support a flag whether to upload metadata to keyserver. This bases on mechanism introduced in D13280

Depends on D13286

Test Plan

This is tested together with next diffs in the stack

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Sep 11 2024, 10:57 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptSep 11 2024, 10:57 AM

bartek added a child revision: D13297: [native] Skip keyserver upload for thick thread avatars.Sep 11 2024, 11:01 AM

Harbormaster completed remote builds in B31540: Diff 44049.Sep 11 2024, 11:19 AM

bartek published this revision for review.Sep 11 2024, 11:30 AM

bartek added inline comments.

native/avatars/avatar-hooks.js
430 ↗	(On Diff #44049)	This will be assigned basing on thread type in D13297

tomek accepted this revision.Sep 12 2024, 12:42 AM

tomek added inline comments.

native/avatars/avatar-hooks.js
56 ↗	(On Diff #44049)	This isn't too readable on the call sites. How about replacing it with `metadataLocation: 'keyserver' \| 'blob_service'`?
248 ↗	(On Diff #44049)	Why do we introduce this call?

This revision is now accepted and ready to land.Sep 12 2024, 12:42 AM

bartek added inline comments.Sep 13 2024, 3:01 AM

native/avatars/avatar-hooks.js
56 ↗	(On Diff #44049)	Metadata location is never blob-service. It's either keyserver or none (then it's caller responsibility to manage this)

tomek added inline comments.Sep 13 2024, 3:24 AM

native/avatars/avatar-hooks.js
56 ↗	(On Diff #44049)	Ah, ok. So maybe `keyserver \| none`?

Apply suggestion

bartek added inline comments.Sep 13 2024, 4:38 AM

native/avatars/avatar-hooks.js
56 ↗	(On Diff #44049)	Yep, this looks much better, thanks!

Harbormaster failed remote builds in B31605: Diff 44150!Sep 13 2024, 4:46 AM

Fix flow

Harbormaster completed remote builds in B31607: Diff 44152.Sep 13 2024, 5:21 AM

Closed by commit rCOMMdf0080acb36e: [native] Update avatar hooks to support skipping keyserver upload (authored by bartek). · Explain WhySep 13 2024, 5:45 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMdf0080acb36e: [native] Update avatar hooks to support skipping keyserver upload.

Revision Contents
Changeset List

Path

Size

native/

account/

registration/

registration-server-call.js

5 lines

avatars/

avatar-hooks.js

58 lines

Diff 44150

native/account/registration/registration-server-call.js

Loading...

native/avatars/avatar-hooks.js

Loading...