Page MenuHomePhabricator

[native] Update avatar hooks to support skipping keyserver upload
ClosedPublic

Authored by bartek on Sep 11 2024, 10:57 AM.
Tags
None
Referenced Files
F3349142: D13294.id44167.diff
Fri, Nov 22, 5:22 PM
F3349139: D13294.id44049.diff
Fri, Nov 22, 5:22 PM
F3349094: D13294.id44152.diff
Fri, Nov 22, 5:06 PM
F3348820: D13294.id44150.diff
Fri, Nov 22, 4:07 PM
F3348792: D13294.id44167.diff
Fri, Nov 22, 4:07 PM
F3348791: D13294.id44152.diff
Fri, Nov 22, 4:07 PM
F3347522: D13294.diff
Fri, Nov 22, 12:28 PM
Unknown Object (File)
Tue, Nov 12, 5:32 PM
Subscribers

Details

Summary

Update avatar-hooks for uploading media to support a flag whether to upload metadata to keyserver. This bases on mechanism introduced in D13280

Depends on D13286

Test Plan

This is tested together with next diffs in the stack

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Sep 11 2024, 11:30 AM
bartek added inline comments.
native/avatars/avatar-hooks.js
430 ↗(On Diff #44049)

This will be assigned basing on thread type in D13297

tomek added inline comments.
native/avatars/avatar-hooks.js
56 ↗(On Diff #44049)

This isn't too readable on the call sites. How about replacing it with metadataLocation: 'keyserver' | 'blob_service'?

248 ↗(On Diff #44049)

Why do we introduce this call?

This revision is now accepted and ready to land.Sep 12 2024, 12:42 AM
native/avatars/avatar-hooks.js
56 ↗(On Diff #44049)

Metadata location is never blob-service. It's either keyserver or none (then it's caller responsibility to manage this)

native/avatars/avatar-hooks.js
56 ↗(On Diff #44049)

Ah, ok. So maybe keyserver | none?

native/avatars/avatar-hooks.js
56 ↗(On Diff #44049)

Yep, this looks much better, thanks!