Page MenuHomePhabricator
Differential D13308

[native] Launch new registration flow and deprecate old one
ClosedPublic
Actions

Authored by ashoat on Sep 12 2024, 11:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 26, 11:37 AM
Unknown Object (File)
Wed, Feb 26, 10:49 AM
Unknown Object (File)
Thu, Feb 20, 2:22 AM
Unknown Object (File)
Thu, Feb 20, 2:22 AM
Unknown Object (File)
Thu, Feb 20, 2:22 AM
Unknown Object (File)
Jan 31 2025, 7:47 PM
Unknown Object (File)
Jan 31 2025, 7:47 PM
Unknown Object (File)
Jan 31 2025, 7:46 PM
View All 51 Files
Subscribers
tomek

Details

Reviewers
varun
will
Commits
rCOMMef817fdddad1: [native] Launch new registration flow and deprecate old one
Summary

Since we've launched the CSAT, we're ready to launch the new registration flow.

This addresses ENG-9261.

Test Plan

Tested on iOS and Android in release mode

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 44176

View Options

native/account/fullscreen-siwe-panel.react.js

Show All 29 Linesimport {
type UseDeleteEntryInput, type UseDeleteEntryInput,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { extractKeyserverIDFromIDOptional } from 'lib/keyserver-conn/keyserver-call-utils.js'; import { extractKeyserverIDFromIDOptional } from 'lib/keyserver-conn/keyserver-call-utils.js';
import { registerFetchKey } from 'lib/reducers/loading-reducer.js'; import { registerFetchKey } from 'lib/reducers/loading-reducer.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js'; import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { colorIsDark } from 'lib/shared/color-utils.js'; import { colorIsDark } from 'lib/shared/color-utils.js';
import { entryKey } from 'lib/shared/entry-utils.js'; import { entryKey } from 'lib/shared/entry-utils.js';
import { useThreadHasPermission } from 'lib/shared/thread-utils.js'; import { useThreadHasPermission } from 'lib/shared/thread-utils.js';
import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { import type {
CalendarQuery, CalendarQuery,
CreateEntryPayload, CreateEntryPayload,
DeleteEntryResult, DeleteEntryResult,
SaveEntryPayload, SaveEntryPayload,
SaveEntryResult, SaveEntryResult,
} from 'lib/types/entry-types.js'; } from 'lib/types/entry-types.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 800 Lines • ▼ Show 20 Lines function ConnectedEntry(props: BaseProps) {
const callCreateEntry = useCreateEntry(); const callCreateEntry = useCreateEntry();
const callSaveEntry = useSaveEntry(); const callSaveEntry = useSaveEntry();
const callDeleteEntry = useDeleteEntry(); const callDeleteEntry = useDeleteEntry();
const { threadInfo: unresolvedThreadInfo, ...restProps } = props; const { threadInfo: unresolvedThreadInfo, ...restProps } = props;
const threadInfo = useResolvedThreadInfo(unresolvedThreadInfo); const threadInfo = useResolvedThreadInfo(unresolvedThreadInfo);
const keyserverID = extractKeyserverIDFromIDOptional(threadInfo.id); const keyserverID = extractKeyserverIDFromIDOptional(threadInfo.id);
const connection = useSelector(state => { const keyserverConnectionStatus = useSelector(state => {
if (!keyserverID) { if (!keyserverID) {
return { return {
status: 'connected', status: 'connected',
}; };
} }
return connectionSelector(keyserverID)(state); return connectionSelector(keyserverID)(state);
}); });
const { socketState } = useTunnelbroker();
invariant( invariant(
connection, keyserverConnectionStatus,
`keyserver ${keyserverID ?? 'null'} missing from keyserverStore`, `keyserver ${keyserverID ?? 'null'} missing from keyserverStore`,
); );
const online = connection.status === 'connected';
const online = threadTypeIsThick(threadInfo.type)
? !!socketState.connected
: keyserverConnectionStatus.status === 'connected';
const canEditEntry = useThreadHasPermission( const canEditEntry = useThreadHasPermission(
threadInfo, threadInfo,
threadPermissions.EDIT_ENTRIES, threadPermissions.EDIT_ENTRIES,
); );
return ( return (
<InternalEntry <InternalEntry
Show All 19 Lines
View Options

native/account/legacy-register-panel.react.js

Show All 29 Linesimport {
type UseDeleteEntryInput, type UseDeleteEntryInput,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { extractKeyserverIDFromIDOptional } from 'lib/keyserver-conn/keyserver-call-utils.js'; import { extractKeyserverIDFromIDOptional } from 'lib/keyserver-conn/keyserver-call-utils.js';
import { registerFetchKey } from 'lib/reducers/loading-reducer.js'; import { registerFetchKey } from 'lib/reducers/loading-reducer.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js'; import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { colorIsDark } from 'lib/shared/color-utils.js'; import { colorIsDark } from 'lib/shared/color-utils.js';
import { entryKey } from 'lib/shared/entry-utils.js'; import { entryKey } from 'lib/shared/entry-utils.js';
import { useThreadHasPermission } from 'lib/shared/thread-utils.js'; import { useThreadHasPermission } from 'lib/shared/thread-utils.js';
import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { import type {
CalendarQuery, CalendarQuery,
CreateEntryPayload, CreateEntryPayload,
DeleteEntryResult, DeleteEntryResult,
SaveEntryPayload, SaveEntryPayload,
SaveEntryResult, SaveEntryResult,
} from 'lib/types/entry-types.js'; } from 'lib/types/entry-types.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 800 Lines • ▼ Show 20 Lines function ConnectedEntry(props: BaseProps) {
const callCreateEntry = useCreateEntry(); const callCreateEntry = useCreateEntry();
const callSaveEntry = useSaveEntry(); const callSaveEntry = useSaveEntry();
const callDeleteEntry = useDeleteEntry(); const callDeleteEntry = useDeleteEntry();
const { threadInfo: unresolvedThreadInfo, ...restProps } = props; const { threadInfo: unresolvedThreadInfo, ...restProps } = props;
const threadInfo = useResolvedThreadInfo(unresolvedThreadInfo); const threadInfo = useResolvedThreadInfo(unresolvedThreadInfo);
const keyserverID = extractKeyserverIDFromIDOptional(threadInfo.id); const keyserverID = extractKeyserverIDFromIDOptional(threadInfo.id);
const connection = useSelector(state => { const keyserverConnectionStatus = useSelector(state => {
if (!keyserverID) { if (!keyserverID) {
return { return {
status: 'connected', status: 'connected',
}; };
} }
return connectionSelector(keyserverID)(state); return connectionSelector(keyserverID)(state);
}); });
const { socketState } = useTunnelbroker();
invariant( invariant(
connection, keyserverConnectionStatus,
`keyserver ${keyserverID ?? 'null'} missing from keyserverStore`, `keyserver ${keyserverID ?? 'null'} missing from keyserverStore`,
); );
const online = connection.status === 'connected';
const online = threadTypeIsThick(threadInfo.type)
? !!socketState.connected
: keyserverConnectionStatus.status === 'connected';
const canEditEntry = useThreadHasPermission( const canEditEntry = useThreadHasPermission(
threadInfo, threadInfo,
threadPermissions.EDIT_ENTRIES, threadPermissions.EDIT_ENTRIES,
); );
return ( return (
<InternalEntry <InternalEntry
Show All 19 Lines
View Options

native/account/logged-out-modal.react.js

Show All 29 Linesimport {
type UseDeleteEntryInput, type UseDeleteEntryInput,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { extractKeyserverIDFromIDOptional } from 'lib/keyserver-conn/keyserver-call-utils.js'; import { extractKeyserverIDFromIDOptional } from 'lib/keyserver-conn/keyserver-call-utils.js';
import { registerFetchKey } from 'lib/reducers/loading-reducer.js'; import { registerFetchKey } from 'lib/reducers/loading-reducer.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js'; import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { colorIsDark } from 'lib/shared/color-utils.js'; import { colorIsDark } from 'lib/shared/color-utils.js';
import { entryKey } from 'lib/shared/entry-utils.js'; import { entryKey } from 'lib/shared/entry-utils.js';
import { useThreadHasPermission } from 'lib/shared/thread-utils.js'; import { useThreadHasPermission } from 'lib/shared/thread-utils.js';
import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { import type {
CalendarQuery, CalendarQuery,
CreateEntryPayload, CreateEntryPayload,
DeleteEntryResult, DeleteEntryResult,
SaveEntryPayload, SaveEntryPayload,
SaveEntryResult, SaveEntryResult,
} from 'lib/types/entry-types.js'; } from 'lib/types/entry-types.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 800 Lines • ▼ Show 20 Lines function ConnectedEntry(props: BaseProps) {
const callCreateEntry = useCreateEntry(); const callCreateEntry = useCreateEntry();
const callSaveEntry = useSaveEntry(); const callSaveEntry = useSaveEntry();
const callDeleteEntry = useDeleteEntry(); const callDeleteEntry = useDeleteEntry();
const { threadInfo: unresolvedThreadInfo, ...restProps } = props; const { threadInfo: unresolvedThreadInfo, ...restProps } = props;
const threadInfo = useResolvedThreadInfo(unresolvedThreadInfo); const threadInfo = useResolvedThreadInfo(unresolvedThreadInfo);
const keyserverID = extractKeyserverIDFromIDOptional(threadInfo.id); const keyserverID = extractKeyserverIDFromIDOptional(threadInfo.id);
const connection = useSelector(state => { const keyserverConnectionStatus = useSelector(state => {
if (!keyserverID) { if (!keyserverID) {
return { return {
status: 'connected', status: 'connected',
}; };
} }
return connectionSelector(keyserverID)(state); return connectionSelector(keyserverID)(state);
}); });
const { socketState } = useTunnelbroker();
invariant( invariant(
connection, keyserverConnectionStatus,
`keyserver ${keyserverID ?? 'null'} missing from keyserverStore`, `keyserver ${keyserverID ?? 'null'} missing from keyserverStore`,
); );
const online = connection.status === 'connected';
const online = threadTypeIsThick(threadInfo.type)
? !!socketState.connected
: keyserverConnectionStatus.status === 'connected';
const canEditEntry = useThreadHasPermission( const canEditEntry = useThreadHasPermission(
threadInfo, threadInfo,
threadPermissions.EDIT_ENTRIES, threadPermissions.EDIT_ENTRIES,
); );
return ( return (
<InternalEntry <InternalEntry
Show All 19 Lines
View Options

native/account/registration/registration-types.js

Show All 29 Linesimport {
type UseDeleteEntryInput, type UseDeleteEntryInput,
} from 'lib/actions/entry-actions.js'; } from 'lib/actions/entry-actions.js';
import { extractKeyserverIDFromIDOptional } from 'lib/keyserver-conn/keyserver-call-utils.js'; import { extractKeyserverIDFromIDOptional } from 'lib/keyserver-conn/keyserver-call-utils.js';
import { registerFetchKey } from 'lib/reducers/loading-reducer.js'; import { registerFetchKey } from 'lib/reducers/loading-reducer.js';
import { connectionSelector } from 'lib/selectors/keyserver-selectors.js'; import { connectionSelector } from 'lib/selectors/keyserver-selectors.js';
import { colorIsDark } from 'lib/shared/color-utils.js'; import { colorIsDark } from 'lib/shared/color-utils.js';
import { entryKey } from 'lib/shared/entry-utils.js'; import { entryKey } from 'lib/shared/entry-utils.js';
import { useThreadHasPermission } from 'lib/shared/thread-utils.js'; import { useThreadHasPermission } from 'lib/shared/thread-utils.js';
import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { import type {
CalendarQuery, CalendarQuery,
CreateEntryPayload, CreateEntryPayload,
DeleteEntryResult, DeleteEntryResult,
SaveEntryPayload, SaveEntryPayload,
SaveEntryResult, SaveEntryResult,
} from 'lib/types/entry-types.js'; } from 'lib/types/entry-types.js';
import type { LoadingStatus } from 'lib/types/loading-types.js'; import type { LoadingStatus } from 'lib/types/loading-types.js';
▲ Show 20 Lines • Show All 800 Lines • ▼ Show 20 Lines function ConnectedEntry(props: BaseProps) {
const callCreateEntry = useCreateEntry(); const callCreateEntry = useCreateEntry();
const callSaveEntry = useSaveEntry(); const callSaveEntry = useSaveEntry();
const callDeleteEntry = useDeleteEntry(); const callDeleteEntry = useDeleteEntry();
const { threadInfo: unresolvedThreadInfo, ...restProps } = props; const { threadInfo: unresolvedThreadInfo, ...restProps } = props;
const threadInfo = useResolvedThreadInfo(unresolvedThreadInfo); const threadInfo = useResolvedThreadInfo(unresolvedThreadInfo);
const keyserverID = extractKeyserverIDFromIDOptional(threadInfo.id); const keyserverID = extractKeyserverIDFromIDOptional(threadInfo.id);
const connection = useSelector(state => { const keyserverConnectionStatus = useSelector(state => {
if (!keyserverID) { if (!keyserverID) {
return { return {
status: 'connected', status: 'connected',
}; };
} }
return connectionSelector(keyserverID)(state); return connectionSelector(keyserverID)(state);
}); });
const { socketState } = useTunnelbroker();
invariant( invariant(
connection, keyserverConnectionStatus,
`keyserver ${keyserverID ?? 'null'} missing from keyserverStore`, `keyserver ${keyserverID ?? 'null'} missing from keyserverStore`,
); );
const online = connection.status === 'connected';
const online = threadTypeIsThick(threadInfo.type)
? !!socketState.connected
: keyserverConnectionStatus.status === 'connected';
const canEditEntry = useThreadHasPermission( const canEditEntry = useThreadHasPermission(
threadInfo, threadInfo,
threadPermissions.EDIT_ENTRIES, threadPermissions.EDIT_ENTRIES,
); );
return ( return (
<InternalEntry <InternalEntry
Show All 19 Lines