Page MenuHomePhabricator

[web] Remove admins tab when there are no admins
ClosedPublic

Authored by tomek on Sep 17 2024, 2:27 AM.
Tags
None
Referenced Files
F3299732: D13359.id44304.diff
Sun, Nov 17, 3:07 PM
F3299542: D13359.diff
Sun, Nov 17, 1:19 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:58 PM
Unknown Object (File)
Sun, Oct 20, 2:57 PM
Unknown Object (File)
Sun, Oct 20, 2:56 PM
Unknown Object (File)
Oct 18 2024, 4:41 PM
Unknown Object (File)
Oct 8 2024, 12:09 PM
Subscribers
None

Details

Summary

In thick threads there are no admins, so it doesn't make sense to show an empty tab. Instead of hiding the tab just for thick threads, we can hide the tab every time there are no admins.

with admins.png (778×514 px, 32 KB)

without admins.png (1×1 px, 192 KB)

https://linear.app/comm/issue/ENG-9258/remove-admins-tab-in-thick-threads

Test Plan

Open a members menu in a thread with some admins and check if both tabs appear. Open it in a thick thread and check if only the members tab is present.

Diff Detail

Repository
rCOMM Comm
Branch
improvements2
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek retitled this revision from [web] Remove admins tab when there are. no admins to [web] Remove admins tab when there are no admins.Sep 17 2024, 2:27 AM
tomek edited reviewers, added: will; removed: bartek, ashoat.
tomek edited the summary of this revision. (Show Details)
tomek requested review of this revision.Sep 17 2024, 2:44 AM
This revision is now accepted and ready to land.Sep 17 2024, 9:53 AM