Page MenuHomePhabricator

[lib] Update the conditions we check before processing the operations
ClosedPublic

Authored by tomek on Tue, Sep 17, 8:47 AM.
Tags
None
Referenced Files
F2751089: D13366.id.diff
Wed, Sep 18, 2:21 PM
Unknown Object (File)
Wed, Sep 18, 8:11 AM
Unknown Object (File)
Tue, Sep 17, 1:45 PM
Unknown Object (File)
Tue, Sep 17, 10:36 AM
Unknown Object (File)
Tue, Sep 17, 9:29 AM
Unknown Object (File)
Tue, Sep 17, 9:29 AM
Unknown Object (File)
Tue, Sep 17, 9:28 AM
Subscribers

Details

Summary

Queue operations when their dependencies aren't satisfied

https://linear.app/comm/issue/ENG-9189/introduce-additional-operation-queues

Depends on D13365

Test Plan

Tested the whole stack at once:

  1. Created an operation with a reaction that was received before an operation creating the message
  2. Created an operation with an edit that was received before an operation creating the message
  3. Created an operation with an entry edit that was received before an operation creating the entry
  4. Created an operation with thread subscription change that was received before the user became a member

In each of the cases verified that the result was correct and that the operation was removed from the queue.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested review of this revision.Tue, Sep 17, 9:10 AM

Update reaction message condition

Fix edit message condition

This revision is now accepted and ready to land.Wed, Sep 18, 9:50 AM