Page MenuHomePhabricator
Differential D13376

[lib] refactor sending `OutboundP2PMessages` to peers
ClosedPublic
Actions

Authored by kamil on Sep 18 2024, 5:15 AM.
Tags
None
Referenced Files
F3320421: D13376.diff
Tue, Nov 19, 10:25 PM
F3318505: D13376.id.diff
Tue, Nov 19, 8:34 PM
Unknown Object (File)
Fri, Nov 1, 9:17 AM
Unknown Object (File)
Tue, Oct 29, 6:11 AM
Unknown Object (File)
Tue, Oct 22, 10:41 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
Unknown Object (File)
Tue, Oct 22, 10:21 AM
View All 40 Files
Subscribers
ashoat

Details

Reviewers
bartek
tomek
marcin
Commits
rCOMMd1a5df1d074a: [lib] refactor sending `OutboundP2PMessages` to peers
Summary

ENG-9106.

New approach, in linked task there is documented what changes and why this is better.

Depends on D13374

Test Plan
  1. Test sending messages when session not exists.
  2. Test sending when session exists.
  3. Make sure notifs still works.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Sep 18 2024, 5:15 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 5:15 AM
Harbormaster completed remote builds in B31684: Diff 44294.Sep 18 2024, 5:32 AM
kamil mentioned this in D13371: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser`.Sep 18 2024, 5:42 AM
kamil mentioned this in D13372: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser` in `PeerOlmSessionCreatorContextType`.
kamil mentioned this in D13373: [lib] refactor notif code to support creating session with multiple devices of one user.
kamil mentioned this in D13374: [lib] refactor methods from `PeerToPeerContext` to utils.
kamil published this revision for review.Sep 18 2024, 5:44 AM
kamil added a child revision: D13384: [lib] make sure `useSendComposableDMOperation` will not throw.Sep 18 2024, 8:06 AM
tomek accepted this revision.Sep 18 2024, 9:32 AM
tomek added inline comments.
lib/tunnelbroker/peer-to-peer-context.js
75 ↗(On Diff #44294)

If we are sure that we can ignore this exception, we should at least add a code comment explaining why.

172 ↗(On Diff #44294)
bartek accepted this revision.Sep 18 2024, 10:55 PM
This revision is now accepted and ready to land.Sep 18 2024, 10:55 PM
kamil updated this revision to Diff 44328.Sep 19 2024, 3:29 AM
  • fix comment
  • add comment
  • rebase
Harbormaster completed remote builds in B31711: Diff 44328.Sep 19 2024, 3:46 AM
Closed by commit rCOMMd1a5df1d074a: [lib] refactor sending `OutboundP2PMessages` to peers (authored by kamil). · Explain WhySep 19 2024, 3:49 AM
This revision was automatically updated to reflect the committed changes.
kamil mentioned this in rCOMM41c7da0e74f0: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser` in….
kamil mentioned this in rCOMMa9f48d77d6a5: [lib] refactor `createOlmSessionWithPeer` -> `createOlmSessionsWithUser`.
kamil mentioned this in rCOMM829c23c21d48: [lib] refactor notif code to support creating session with multiple devices of….
kamil mentioned this in rCOMM3aca795e8ca2: [lib] refactor methods from `PeerToPeerContext` to utils.
kamil added a commit: rCOMMd1a5df1d074a: [lib] refactor sending `OutboundP2PMessages` to peers.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
310 lines

Diff 44328

View Options

lib/tunnelbroker/peer-to-peer-context.js

Loading...