Page MenuHomePhabricator

[lib] Update the conditions we check before processing the operations
ClosedPublic

Authored by tomek on Sep 17 2024, 8:47 AM.
Tags
None
Referenced Files
F3521456: D13366.id44295.diff
Mon, Dec 23, 3:35 AM
F3521419: D13366.id44302.diff
Mon, Dec 23, 3:28 AM
F3520278: D13366.diff
Sun, Dec 22, 11:52 PM
Unknown Object (File)
Nov 20 2024, 7:02 AM
Unknown Object (File)
Nov 20 2024, 6:40 AM
Unknown Object (File)
Nov 9 2024, 10:26 PM
Unknown Object (File)
Nov 9 2024, 8:33 PM
Unknown Object (File)
Oct 22 2024, 10:41 AM
Subscribers

Details

Summary

Queue operations when their dependencies aren't satisfied

https://linear.app/comm/issue/ENG-9189/introduce-additional-operation-queues

Depends on D13365

Test Plan

Tested the whole stack at once:

  1. Created an operation with a reaction that was received before an operation creating the message
  2. Created an operation with an edit that was received before an operation creating the message
  3. Created an operation with an entry edit that was received before an operation creating the entry
  4. Created an operation with thread subscription change that was received before the user became a member

In each of the cases verified that the result was correct and that the operation was removed from the queue.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Sep 17 2024, 9:10 AM

Update reaction message condition

Fix edit message condition

This revision is now accepted and ready to land.Sep 18 2024, 9:50 AM