Page MenuHomePhabricator
Differential D13385

[lib] remove `outboundP2PMessages` for devices removed from device list
ClosedPublic
Actions

Authored by kamil on Sep 18 2024, 9:07 AM.
Tags
None
Referenced Files
F3012522: D13385.id44385.diff
Sat, Oct 19, 3:35 AM
F3012491: D13385.id44338.diff
Sat, Oct 19, 3:28 AM
F3011581: D13385.id44318.diff
Sat, Oct 19, 1:38 AM
Unknown Object (File)
Thu, Oct 10, 4:31 PM
Unknown Object (File)
Thu, Oct 10, 11:00 AM
Unknown Object (File)
Wed, Oct 9, 10:28 AM
Unknown Object (File)
Fri, Oct 4, 2:54 AM
Unknown Object (File)
Wed, Oct 2, 4:38 AM
View All 31 Files
Subscribers
ashoat

Details

Reviewers
tomek
bartek
Commits
rCOMMd2363bcedd18: [lib] remove `outboundP2PMessages` for devices removed from device list
Summary

Fix for ENG-9336.

Test Plan

Test case described in ENG-9336

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Sep 18 2024, 9:07 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptSep 18 2024, 9:07 AM
kamil published this revision for review.Sep 18 2024, 9:09 AM
Harbormaster completed remote builds in B31703: Diff 44318.Sep 18 2024, 9:25 AM
tomek requested changes to this revision.Sep 18 2024, 9:41 AM

It might be a better idea to clear the messages when a device is removed from the device list.

Also, we should clear auto-retriable messages that aren't scheduled using this queue.

This revision now requires changes to proceed.Sep 18 2024, 9:41 AM
kamil updated this revision to Diff 44338.Sep 19 2024, 4:13 AM

remove auto-retriable messages too

kamil added a comment.Sep 19 2024, 4:14 AM
In D13385#376821, @tomek wrote:

It might be a better idea to clear the messages when a device is removed from the device list.

Created ENG-9338 to track.

Also, we should clear auto-retriable messages that aren't scheduled using this queue.

Addressed

Harbormaster completed remote builds in B31714: Diff 44338.Sep 19 2024, 4:30 AM
tomek accepted this revision.Fri, Sep 20, 2:23 AM
This revision is now accepted and ready to land.Fri, Sep 20, 2:23 AM
bartek accepted this revision.Fri, Sep 20, 4:45 AM
Closed by commit rCOMMd2363bcedd18: [lib] remove `outboundP2PMessages` for devices removed from device list (authored by kamil). · Explain WhyFri, Sep 20, 7:16 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMd2363bcedd18: [lib] remove `outboundP2PMessages` for devices removed from device list.

Revision Contents
Changeset List

PathSize
lib/
tunnelbroker/
42 lines

Diff 44385

View Options

lib/tunnelbroker/peer-to-peer-context.js

Loading...