Page MenuHomePhabricator
Differential D13423

[lib] Enable thick thread creation for all the users
ClosedPublic
Actions

Authored by tomek on Sep 23 2024, 3:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 8:19 PM
Unknown Object (File)
Mon, Mar 3, 6:17 AM
Unknown Object (File)
Feb 24 2025, 5:32 AM
Unknown Object (File)
Feb 18 2025, 10:51 AM
Unknown Object (File)
Feb 15 2025, 7:39 PM
Unknown Object (File)
Feb 15 2025, 7:39 PM
Unknown Object (File)
Feb 15 2025, 7:39 PM
Unknown Object (File)
Feb 15 2025, 7:38 PM
View All 79 Files
Subscribers
ashoat

Details

Reviewers
kamil
will
inka
Commits
rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users
Summary

Delete a hook that was limiting this options to the staff users.

https://linear.app/comm/issue/ENG-9360/enable-thick-threads-for-all-the-users

Test Plan

Flow. A sanity check about creating and leaving a thread.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Sep 23 2024, 3:41 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 23 2024, 3:42 AM
tomek edited the summary of this revision. (Show Details)Sep 23 2024, 3:43 AM
Harbormaster completed remote builds in B31763: Diff 44409.Sep 23 2024, 3:58 AM
tomek requested review of this revision.Sep 23 2024, 3:58 AM
kamil accepted this revision.Sep 23 2024, 4:15 AM
This revision is now accepted and ready to land.Sep 23 2024, 4:15 AM
tomek updated this revision to Diff 44527.Sep 25 2024, 4:03 AM

Rebase

Harbormaster completed remote builds in B31839: Diff 44527.Sep 25 2024, 4:20 AM
tomek updated this revision to Diff 44690.Sep 30 2024, 8:42 AM

Rebase

inka accepted this revision.Sep 30 2024, 8:47 AM
tomek edited the test plan for this revision. (Show Details)Sep 30 2024, 8:53 AM
Harbormaster completed remote builds in B31934: Diff 44690.Sep 30 2024, 8:59 AM
Closed by commit rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users (authored by tomek). · Explain WhySep 30 2024, 9:00 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users.

Revision Contents
Changeset List

Diff 44527

View Options

lib/hooks/flag-hooks.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import _maxBy from 'lodash/fp/maxBy.js'; import _maxBy from 'lodash/fp/maxBy.js';
import _orderBy from 'lodash/fp/orderBy.js'; import _orderBy from 'lodash/fp/orderBy.js';
import * as React from 'react'; import * as React from 'react';
import { codeBlockRegex, type ParserRules } from './markdown.js'; import { codeBlockRegex, type ParserRules } from './markdown.js';
import type { CreationSideEffectsFunc } from './messages/message-spec.js'; import type { CreationSideEffectsFunc } from './messages/message-spec.js';
import { messageSpecs } from './messages/message-specs.js'; import { messageSpecs } from './messages/message-specs.js';
import { threadIsGroupChat } from './thread-utils.js'; import { threadIsGroupChat } from './thread-utils.js';
import { useStringForUser } from '../hooks/ens-cache.js'; import { useStringForUser } from '../hooks/ens-cache.js';
import { contentStringForMediaArray } from '../media/media-utils.js';
import { userIDsToRelativeUserInfos } from '../selectors/user-selectors.js'; import { userIDsToRelativeUserInfos } from '../selectors/user-selectors.js';
import { type PlatformDetails, isWebPlatform } from '../types/device-types.js'; import { type PlatformDetails, isWebPlatform } from '../types/device-types.js';
import type { Media } from '../types/media-types.js'; import type { Media } from '../types/media-types.js';
import { import {
type MessageInfo, type MessageInfo,
type RawMessageInfo, type RawMessageInfo,
type RobotextMessageInfo, type RobotextMessageInfo,
type RawMultimediaMessageInfo, type RawMultimediaMessageInfo,
▲ Show 20 Lines • Show All 543 Lines • ▼ Show 20 Lines): CreationSideEffectsFunc<Info> {
invariant(messageSpec, `we're not aware of messageType ${messageType}`); invariant(messageSpec, `we're not aware of messageType ${messageType}`);
invariant( invariant(
messageSpec.useCreationSideEffectsFunc, messageSpec.useCreationSideEffectsFunc,
`no useCreationSideEffectsFunc in message spec for ${messageType}`, `no useCreationSideEffectsFunc in message spec for ${messageType}`,
); );
return messageSpec.useCreationSideEffectsFunc(); return messageSpec.useCreationSideEffectsFunc();
} }
function getPinnedContentFromMessage(targetMessage: RawMessageInfo): string {
let pinnedContent;
if (
targetMessage.type === messageTypes.IMAGES ||
targetMessage.type === messageTypes.MULTIMEDIA
) {
pinnedContent = contentStringForMediaArray(targetMessage.media);
} else {
pinnedContent = 'a message';
}
return pinnedContent;
}
export { export {
localIDPrefix, localIDPrefix,
messageKey, messageKey,
messageID, messageID,
robotextForMessageInfo, robotextForMessageInfo,
createMessageInfo, createMessageInfo,
sortMessageInfoList, sortMessageInfoList,
sortMessageIDs, sortMessageIDs,
rawMessageInfoFromMessageData, rawMessageInfoFromMessageData,
mostRecentMessageTimestamp, mostRecentMessageTimestamp,
usersInMessageInfos, usersInMessageInfos,
combineTruncationStatuses, combineTruncationStatuses,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
createMediaMessageData, createMediaMessageData,
createMediaMessageInfo, createMediaMessageInfo,
stripLocalIDs, stripLocalIDs,
trimMessage, trimMessage,
createMessageQuote, createMessageQuote,
createMessageReply, createMessageReply,
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
getMessageTitle, getMessageTitle,
mergeThreadMessageInfos, mergeThreadMessageInfos,
useMessagePreview, useMessagePreview,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getPinnedContentFromMessage,
}; };
View Options

lib/hooks/relationship-hooks.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import _maxBy from 'lodash/fp/maxBy.js'; import _maxBy from 'lodash/fp/maxBy.js';
import _orderBy from 'lodash/fp/orderBy.js'; import _orderBy from 'lodash/fp/orderBy.js';
import * as React from 'react'; import * as React from 'react';
import { codeBlockRegex, type ParserRules } from './markdown.js'; import { codeBlockRegex, type ParserRules } from './markdown.js';
import type { CreationSideEffectsFunc } from './messages/message-spec.js'; import type { CreationSideEffectsFunc } from './messages/message-spec.js';
import { messageSpecs } from './messages/message-specs.js'; import { messageSpecs } from './messages/message-specs.js';
import { threadIsGroupChat } from './thread-utils.js'; import { threadIsGroupChat } from './thread-utils.js';
import { useStringForUser } from '../hooks/ens-cache.js'; import { useStringForUser } from '../hooks/ens-cache.js';
import { contentStringForMediaArray } from '../media/media-utils.js';
import { userIDsToRelativeUserInfos } from '../selectors/user-selectors.js'; import { userIDsToRelativeUserInfos } from '../selectors/user-selectors.js';
import { type PlatformDetails, isWebPlatform } from '../types/device-types.js'; import { type PlatformDetails, isWebPlatform } from '../types/device-types.js';
import type { Media } from '../types/media-types.js'; import type { Media } from '../types/media-types.js';
import { import {
type MessageInfo, type MessageInfo,
type RawMessageInfo, type RawMessageInfo,
type RobotextMessageInfo, type RobotextMessageInfo,
type RawMultimediaMessageInfo, type RawMultimediaMessageInfo,
▲ Show 20 Lines • Show All 543 Lines • ▼ Show 20 Lines): CreationSideEffectsFunc<Info> {
invariant(messageSpec, `we're not aware of messageType ${messageType}`); invariant(messageSpec, `we're not aware of messageType ${messageType}`);
invariant( invariant(
messageSpec.useCreationSideEffectsFunc, messageSpec.useCreationSideEffectsFunc,
`no useCreationSideEffectsFunc in message spec for ${messageType}`, `no useCreationSideEffectsFunc in message spec for ${messageType}`,
); );
return messageSpec.useCreationSideEffectsFunc(); return messageSpec.useCreationSideEffectsFunc();
} }
function getPinnedContentFromMessage(targetMessage: RawMessageInfo): string {
let pinnedContent;
if (
targetMessage.type === messageTypes.IMAGES ||
targetMessage.type === messageTypes.MULTIMEDIA
) {
pinnedContent = contentStringForMediaArray(targetMessage.media);
} else {
pinnedContent = 'a message';
}
return pinnedContent;
}
export { export {
localIDPrefix, localIDPrefix,
messageKey, messageKey,
messageID, messageID,
robotextForMessageInfo, robotextForMessageInfo,
createMessageInfo, createMessageInfo,
sortMessageInfoList, sortMessageInfoList,
sortMessageIDs, sortMessageIDs,
rawMessageInfoFromMessageData, rawMessageInfoFromMessageData,
mostRecentMessageTimestamp, mostRecentMessageTimestamp,
usersInMessageInfos, usersInMessageInfos,
combineTruncationStatuses, combineTruncationStatuses,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
createMediaMessageData, createMediaMessageData,
createMediaMessageInfo, createMediaMessageInfo,
stripLocalIDs, stripLocalIDs,
trimMessage, trimMessage,
createMessageQuote, createMessageQuote,
createMessageReply, createMessageReply,
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
getMessageTitle, getMessageTitle,
mergeThreadMessageInfos, mergeThreadMessageInfos,
useMessagePreview, useMessagePreview,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getPinnedContentFromMessage,
}; };
View Options

lib/selectors/thread-selectors.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import _maxBy from 'lodash/fp/maxBy.js'; import _maxBy from 'lodash/fp/maxBy.js';
import _orderBy from 'lodash/fp/orderBy.js'; import _orderBy from 'lodash/fp/orderBy.js';
import * as React from 'react'; import * as React from 'react';
import { codeBlockRegex, type ParserRules } from './markdown.js'; import { codeBlockRegex, type ParserRules } from './markdown.js';
import type { CreationSideEffectsFunc } from './messages/message-spec.js'; import type { CreationSideEffectsFunc } from './messages/message-spec.js';
import { messageSpecs } from './messages/message-specs.js'; import { messageSpecs } from './messages/message-specs.js';
import { threadIsGroupChat } from './thread-utils.js'; import { threadIsGroupChat } from './thread-utils.js';
import { useStringForUser } from '../hooks/ens-cache.js'; import { useStringForUser } from '../hooks/ens-cache.js';
import { contentStringForMediaArray } from '../media/media-utils.js';
import { userIDsToRelativeUserInfos } from '../selectors/user-selectors.js'; import { userIDsToRelativeUserInfos } from '../selectors/user-selectors.js';
import { type PlatformDetails, isWebPlatform } from '../types/device-types.js'; import { type PlatformDetails, isWebPlatform } from '../types/device-types.js';
import type { Media } from '../types/media-types.js'; import type { Media } from '../types/media-types.js';
import { import {
type MessageInfo, type MessageInfo,
type RawMessageInfo, type RawMessageInfo,
type RobotextMessageInfo, type RobotextMessageInfo,
type RawMultimediaMessageInfo, type RawMultimediaMessageInfo,
▲ Show 20 Lines • Show All 543 Lines • ▼ Show 20 Lines): CreationSideEffectsFunc<Info> {
invariant(messageSpec, `we're not aware of messageType ${messageType}`); invariant(messageSpec, `we're not aware of messageType ${messageType}`);
invariant( invariant(
messageSpec.useCreationSideEffectsFunc, messageSpec.useCreationSideEffectsFunc,
`no useCreationSideEffectsFunc in message spec for ${messageType}`, `no useCreationSideEffectsFunc in message spec for ${messageType}`,
); );
return messageSpec.useCreationSideEffectsFunc(); return messageSpec.useCreationSideEffectsFunc();
} }
function getPinnedContentFromMessage(targetMessage: RawMessageInfo): string {
let pinnedContent;
if (
targetMessage.type === messageTypes.IMAGES ||
targetMessage.type === messageTypes.MULTIMEDIA
) {
pinnedContent = contentStringForMediaArray(targetMessage.media);
} else {
pinnedContent = 'a message';
}
return pinnedContent;
}
export { export {
localIDPrefix, localIDPrefix,
messageKey, messageKey,
messageID, messageID,
robotextForMessageInfo, robotextForMessageInfo,
createMessageInfo, createMessageInfo,
sortMessageInfoList, sortMessageInfoList,
sortMessageIDs, sortMessageIDs,
rawMessageInfoFromMessageData, rawMessageInfoFromMessageData,
mostRecentMessageTimestamp, mostRecentMessageTimestamp,
usersInMessageInfos, usersInMessageInfos,
combineTruncationStatuses, combineTruncationStatuses,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
createMediaMessageData, createMediaMessageData,
createMediaMessageInfo, createMediaMessageInfo,
stripLocalIDs, stripLocalIDs,
trimMessage, trimMessage,
createMessageQuote, createMessageQuote,
createMessageReply, createMessageReply,
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
getMessageTitle, getMessageTitle,
mergeThreadMessageInfos, mergeThreadMessageInfos,
useMessagePreview, useMessagePreview,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getPinnedContentFromMessage,
}; };
View Options

lib/shared/thread-actions-utils.js

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import _maxBy from 'lodash/fp/maxBy.js'; import _maxBy from 'lodash/fp/maxBy.js';
import _orderBy from 'lodash/fp/orderBy.js'; import _orderBy from 'lodash/fp/orderBy.js';
import * as React from 'react'; import * as React from 'react';
import { codeBlockRegex, type ParserRules } from './markdown.js'; import { codeBlockRegex, type ParserRules } from './markdown.js';
import type { CreationSideEffectsFunc } from './messages/message-spec.js'; import type { CreationSideEffectsFunc } from './messages/message-spec.js';
import { messageSpecs } from './messages/message-specs.js'; import { messageSpecs } from './messages/message-specs.js';
import { threadIsGroupChat } from './thread-utils.js'; import { threadIsGroupChat } from './thread-utils.js';
import { useStringForUser } from '../hooks/ens-cache.js'; import { useStringForUser } from '../hooks/ens-cache.js';
import { contentStringForMediaArray } from '../media/media-utils.js';
import { userIDsToRelativeUserInfos } from '../selectors/user-selectors.js'; import { userIDsToRelativeUserInfos } from '../selectors/user-selectors.js';
import { type PlatformDetails, isWebPlatform } from '../types/device-types.js'; import { type PlatformDetails, isWebPlatform } from '../types/device-types.js';
import type { Media } from '../types/media-types.js'; import type { Media } from '../types/media-types.js';
import { import {
type MessageInfo, type MessageInfo,
type RawMessageInfo, type RawMessageInfo,
type RobotextMessageInfo, type RobotextMessageInfo,
type RawMultimediaMessageInfo, type RawMultimediaMessageInfo,
▲ Show 20 Lines • Show All 543 Lines • ▼ Show 20 Lines): CreationSideEffectsFunc<Info> {
invariant(messageSpec, `we're not aware of messageType ${messageType}`); invariant(messageSpec, `we're not aware of messageType ${messageType}`);
invariant( invariant(
messageSpec.useCreationSideEffectsFunc, messageSpec.useCreationSideEffectsFunc,
`no useCreationSideEffectsFunc in message spec for ${messageType}`, `no useCreationSideEffectsFunc in message spec for ${messageType}`,
); );
return messageSpec.useCreationSideEffectsFunc(); return messageSpec.useCreationSideEffectsFunc();
} }
function getPinnedContentFromMessage(targetMessage: RawMessageInfo): string {
let pinnedContent;
if (
targetMessage.type === messageTypes.IMAGES ||
targetMessage.type === messageTypes.MULTIMEDIA
) {
pinnedContent = contentStringForMediaArray(targetMessage.media);
} else {
pinnedContent = 'a message';
}
return pinnedContent;
}
export { export {
localIDPrefix, localIDPrefix,
messageKey, messageKey,
messageID, messageID,
robotextForMessageInfo, robotextForMessageInfo,
createMessageInfo, createMessageInfo,
sortMessageInfoList, sortMessageInfoList,
sortMessageIDs, sortMessageIDs,
rawMessageInfoFromMessageData, rawMessageInfoFromMessageData,
mostRecentMessageTimestamp, mostRecentMessageTimestamp,
usersInMessageInfos, usersInMessageInfos,
combineTruncationStatuses, combineTruncationStatuses,
shimUnsupportedRawMessageInfos, shimUnsupportedRawMessageInfos,
createMediaMessageData, createMediaMessageData,
createMediaMessageInfo, createMediaMessageInfo,
stripLocalIDs, stripLocalIDs,
trimMessage, trimMessage,
createMessageQuote, createMessageQuote,
createMessageReply, createMessageReply,
getMostRecentNonLocalMessageID, getMostRecentNonLocalMessageID,
getMessageTitle, getMessageTitle,
mergeThreadMessageInfos, mergeThreadMessageInfos,
useMessagePreview, useMessagePreview,
useMessageCreationSideEffectsFunc, useMessageCreationSideEffectsFunc,
getPinnedContentFromMessage,
}; };
View Options

lib/shared/thread-utils.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/chat/compose-thread-button.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/chat/thread-list-provider.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/utils/thread-utils.js

Loading...