Page MenuHomePhabricator
Differential D13423

[lib] Enable thick thread creation for all the users
ClosedPublic
Actions

Authored by tomek on Sep 23 2024, 3:41 AM.
Tags
None
Referenced Files
F6237675: D13423.diff
Thu, Apr 24, 4:58 PM
F6237593: D13423.diff
Thu, Apr 24, 4:52 PM
Unknown Object (File)
Wed, Apr 16, 4:07 PM
Unknown Object (File)
Wed, Apr 16, 10:42 AM
Unknown Object (File)
Wed, Apr 16, 3:26 AM
Unknown Object (File)
Wed, Apr 16, 1:30 AM
Unknown Object (File)
Tue, Apr 15, 10:10 PM
Unknown Object (File)
Tue, Apr 15, 1:40 PM
View All 90 Files
Subscribers
ashoat

Details

Reviewers
kamil
will
inka
Commits
rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users
Summary

Delete a hook that was limiting this options to the staff users.

https://linear.app/comm/issue/ENG-9360/enable-thick-threads-for-all-the-users

Test Plan

Flow. A sanity check about creating and leaving a thread.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Sep 23 2024, 3:41 AM
Herald added a subscriber: ashoat. · View Herald TranscriptSep 23 2024, 3:42 AM
tomek edited the summary of this revision. (Show Details)Sep 23 2024, 3:43 AM
Harbormaster completed remote builds in B31763: Diff 44409.Sep 23 2024, 3:58 AM
tomek requested review of this revision.Sep 23 2024, 3:58 AM
kamil accepted this revision.Sep 23 2024, 4:15 AM
This revision is now accepted and ready to land.Sep 23 2024, 4:15 AM
tomek updated this revision to Diff 44527.Sep 25 2024, 4:03 AM

Rebase

Harbormaster completed remote builds in B31839: Diff 44527.Sep 25 2024, 4:20 AM
tomek updated this revision to Diff 44690.Sep 30 2024, 8:42 AM

Rebase

inka accepted this revision.Sep 30 2024, 8:47 AM
tomek edited the test plan for this revision. (Show Details)Sep 30 2024, 8:53 AM
Harbormaster completed remote builds in B31934: Diff 44690.Sep 30 2024, 8:59 AM
Closed by commit rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users (authored by tomek). · Explain WhySep 30 2024, 9:00 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMM6eea5aaa53ce: [lib] Enable thick thread creation for all the users.

Revision Contents
Changeset List

Diff 44527

View Options

lib/hooks/flag-hooks.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
getFCNames as baseGetFCNames, getFCNames as baseGetFCNames,
type BaseFCInfo, getFCAvatarURLs as baseGetFCAvatarURLs,
type BaseFCNamesInfo,
type BaseFCAvatarInfo,
type GetFCNames, type GetFCNames,
type GetFCAvatarURLs,
} from '../utils/farcaster-helpers.js'; } from '../utils/farcaster-helpers.js';
import { FCCache } from '../utils/fc-cache.js'; import { FCCache } from '../utils/fc-cache.js';
import { NeynarClient } from '../utils/neynar-client.js'; import { NeynarClient } from '../utils/neynar-client.js';
type NeynarClientContextType = { type NeynarClientContextType = {
+client: NeynarClient, +client: NeynarClient,
+fcCache: FCCache, +fcCache: FCCache,
+getFCNames: GetFCNames, +getFCNames: GetFCNames,
+getFCAvatarURLs: GetFCAvatarURLs,
}; };
const NeynarClientContext: React.Context<?NeynarClientContextType> = const NeynarClientContext: React.Context<?NeynarClientContextType> =
React.createContext<?NeynarClientContextType>(); React.createContext<?NeynarClientContextType>();
type Props = { type Props = {
+apiKey: ?string, +apiKey: ?string,
+children: React.Node, +children: React.Node,
}; };
function NeynarClientProvider(props: Props): React.Node { function NeynarClientProvider(props: Props): React.Node {
const { apiKey, children } = props; const { apiKey, children } = props;
const neynarClient = React.useMemo(() => { const neynarClient = React.useMemo(() => {
if (!apiKey) { if (!apiKey) {
return null; return null;
} }
return new NeynarClient(apiKey); return new NeynarClient(apiKey);
}, [apiKey]); }, [apiKey]);
const context = React.useMemo(() => { const context = React.useMemo(() => {
if (!neynarClient) { if (!neynarClient) {
return null; return null;
} }
const fcCache = new FCCache(neynarClient); const fcCache = new FCCache(neynarClient);
const getFCNames: GetFCNames = <T: ?BaseFCInfo>( const getFCNames: GetFCNames = <T: ?BaseFCNamesInfo>(
users: $ReadOnlyArray<T>, users: $ReadOnlyArray<T>,
): Promise<T[]> => baseGetFCNames(fcCache, users); ): Promise<T[]> => baseGetFCNames(fcCache, users);
const getFCAvatarURLs: GetFCAvatarURLs = (
fids: $ReadOnlyArray<string>,
): Promise<BaseFCAvatarInfo[]> => baseGetFCAvatarURLs(fcCache, fids);
return { return {
client: neynarClient, client: neynarClient,
fcCache, fcCache,
getFCNames, getFCNames,
getFCAvatarURLs,
}; };
}, [neynarClient]); }, [neynarClient]);
return ( return (
<NeynarClientContext.Provider value={context}> <NeynarClientContext.Provider value={context}>
{children} {children}
</NeynarClientContext.Provider> </NeynarClientContext.Provider>
); );
} }
export { NeynarClientContext, NeynarClientProvider }; export { NeynarClientContext, NeynarClientProvider };
View Options

lib/hooks/relationship-hooks.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
getFCNames as baseGetFCNames, getFCNames as baseGetFCNames,
type BaseFCInfo, getFCAvatarURLs as baseGetFCAvatarURLs,
type BaseFCNamesInfo,
type BaseFCAvatarInfo,
type GetFCNames, type GetFCNames,
type GetFCAvatarURLs,
} from '../utils/farcaster-helpers.js'; } from '../utils/farcaster-helpers.js';
import { FCCache } from '../utils/fc-cache.js'; import { FCCache } from '../utils/fc-cache.js';
import { NeynarClient } from '../utils/neynar-client.js'; import { NeynarClient } from '../utils/neynar-client.js';
type NeynarClientContextType = { type NeynarClientContextType = {
+client: NeynarClient, +client: NeynarClient,
+fcCache: FCCache, +fcCache: FCCache,
+getFCNames: GetFCNames, +getFCNames: GetFCNames,
+getFCAvatarURLs: GetFCAvatarURLs,
}; };
const NeynarClientContext: React.Context<?NeynarClientContextType> = const NeynarClientContext: React.Context<?NeynarClientContextType> =
React.createContext<?NeynarClientContextType>(); React.createContext<?NeynarClientContextType>();
type Props = { type Props = {
+apiKey: ?string, +apiKey: ?string,
+children: React.Node, +children: React.Node,
}; };
function NeynarClientProvider(props: Props): React.Node { function NeynarClientProvider(props: Props): React.Node {
const { apiKey, children } = props; const { apiKey, children } = props;
const neynarClient = React.useMemo(() => { const neynarClient = React.useMemo(() => {
if (!apiKey) { if (!apiKey) {
return null; return null;
} }
return new NeynarClient(apiKey); return new NeynarClient(apiKey);
}, [apiKey]); }, [apiKey]);
const context = React.useMemo(() => { const context = React.useMemo(() => {
if (!neynarClient) { if (!neynarClient) {
return null; return null;
} }
const fcCache = new FCCache(neynarClient); const fcCache = new FCCache(neynarClient);
const getFCNames: GetFCNames = <T: ?BaseFCInfo>( const getFCNames: GetFCNames = <T: ?BaseFCNamesInfo>(
users: $ReadOnlyArray<T>, users: $ReadOnlyArray<T>,
): Promise<T[]> => baseGetFCNames(fcCache, users); ): Promise<T[]> => baseGetFCNames(fcCache, users);
const getFCAvatarURLs: GetFCAvatarURLs = (
fids: $ReadOnlyArray<string>,
): Promise<BaseFCAvatarInfo[]> => baseGetFCAvatarURLs(fcCache, fids);
return { return {
client: neynarClient, client: neynarClient,
fcCache, fcCache,
getFCNames, getFCNames,
getFCAvatarURLs,
}; };
}, [neynarClient]); }, [neynarClient]);
return ( return (
<NeynarClientContext.Provider value={context}> <NeynarClientContext.Provider value={context}>
{children} {children}
</NeynarClientContext.Provider> </NeynarClientContext.Provider>
); );
} }
export { NeynarClientContext, NeynarClientProvider }; export { NeynarClientContext, NeynarClientProvider };
View Options

lib/selectors/thread-selectors.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
getFCNames as baseGetFCNames, getFCNames as baseGetFCNames,
type BaseFCInfo, getFCAvatarURLs as baseGetFCAvatarURLs,
type BaseFCNamesInfo,
type BaseFCAvatarInfo,
type GetFCNames, type GetFCNames,
type GetFCAvatarURLs,
} from '../utils/farcaster-helpers.js'; } from '../utils/farcaster-helpers.js';
import { FCCache } from '../utils/fc-cache.js'; import { FCCache } from '../utils/fc-cache.js';
import { NeynarClient } from '../utils/neynar-client.js'; import { NeynarClient } from '../utils/neynar-client.js';
type NeynarClientContextType = { type NeynarClientContextType = {
+client: NeynarClient, +client: NeynarClient,
+fcCache: FCCache, +fcCache: FCCache,
+getFCNames: GetFCNames, +getFCNames: GetFCNames,
+getFCAvatarURLs: GetFCAvatarURLs,
}; };
const NeynarClientContext: React.Context<?NeynarClientContextType> = const NeynarClientContext: React.Context<?NeynarClientContextType> =
React.createContext<?NeynarClientContextType>(); React.createContext<?NeynarClientContextType>();
type Props = { type Props = {
+apiKey: ?string, +apiKey: ?string,
+children: React.Node, +children: React.Node,
}; };
function NeynarClientProvider(props: Props): React.Node { function NeynarClientProvider(props: Props): React.Node {
const { apiKey, children } = props; const { apiKey, children } = props;
const neynarClient = React.useMemo(() => { const neynarClient = React.useMemo(() => {
if (!apiKey) { if (!apiKey) {
return null; return null;
} }
return new NeynarClient(apiKey); return new NeynarClient(apiKey);
}, [apiKey]); }, [apiKey]);
const context = React.useMemo(() => { const context = React.useMemo(() => {
if (!neynarClient) { if (!neynarClient) {
return null; return null;
} }
const fcCache = new FCCache(neynarClient); const fcCache = new FCCache(neynarClient);
const getFCNames: GetFCNames = <T: ?BaseFCInfo>( const getFCNames: GetFCNames = <T: ?BaseFCNamesInfo>(
users: $ReadOnlyArray<T>, users: $ReadOnlyArray<T>,
): Promise<T[]> => baseGetFCNames(fcCache, users); ): Promise<T[]> => baseGetFCNames(fcCache, users);
const getFCAvatarURLs: GetFCAvatarURLs = (
fids: $ReadOnlyArray<string>,
): Promise<BaseFCAvatarInfo[]> => baseGetFCAvatarURLs(fcCache, fids);
return { return {
client: neynarClient, client: neynarClient,
fcCache, fcCache,
getFCNames, getFCNames,
getFCAvatarURLs,
}; };
}, [neynarClient]); }, [neynarClient]);
return ( return (
<NeynarClientContext.Provider value={context}> <NeynarClientContext.Provider value={context}>
{children} {children}
</NeynarClientContext.Provider> </NeynarClientContext.Provider>
); );
} }
export { NeynarClientContext, NeynarClientProvider }; export { NeynarClientContext, NeynarClientProvider };
View Options

lib/shared/thread-actions-utils.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { import {
getFCNames as baseGetFCNames, getFCNames as baseGetFCNames,
type BaseFCInfo, getFCAvatarURLs as baseGetFCAvatarURLs,
type BaseFCNamesInfo,
type BaseFCAvatarInfo,
type GetFCNames, type GetFCNames,
type GetFCAvatarURLs,
} from '../utils/farcaster-helpers.js'; } from '../utils/farcaster-helpers.js';
import { FCCache } from '../utils/fc-cache.js'; import { FCCache } from '../utils/fc-cache.js';
import { NeynarClient } from '../utils/neynar-client.js'; import { NeynarClient } from '../utils/neynar-client.js';
type NeynarClientContextType = { type NeynarClientContextType = {
+client: NeynarClient, +client: NeynarClient,
+fcCache: FCCache, +fcCache: FCCache,
+getFCNames: GetFCNames, +getFCNames: GetFCNames,
+getFCAvatarURLs: GetFCAvatarURLs,
}; };
const NeynarClientContext: React.Context<?NeynarClientContextType> = const NeynarClientContext: React.Context<?NeynarClientContextType> =
React.createContext<?NeynarClientContextType>(); React.createContext<?NeynarClientContextType>();
type Props = { type Props = {
+apiKey: ?string, +apiKey: ?string,
+children: React.Node, +children: React.Node,
}; };
function NeynarClientProvider(props: Props): React.Node { function NeynarClientProvider(props: Props): React.Node {
const { apiKey, children } = props; const { apiKey, children } = props;
const neynarClient = React.useMemo(() => { const neynarClient = React.useMemo(() => {
if (!apiKey) { if (!apiKey) {
return null; return null;
} }
return new NeynarClient(apiKey); return new NeynarClient(apiKey);
}, [apiKey]); }, [apiKey]);
const context = React.useMemo(() => { const context = React.useMemo(() => {
if (!neynarClient) { if (!neynarClient) {
return null; return null;
} }
const fcCache = new FCCache(neynarClient); const fcCache = new FCCache(neynarClient);
const getFCNames: GetFCNames = <T: ?BaseFCInfo>( const getFCNames: GetFCNames = <T: ?BaseFCNamesInfo>(
users: $ReadOnlyArray<T>, users: $ReadOnlyArray<T>,
): Promise<T[]> => baseGetFCNames(fcCache, users); ): Promise<T[]> => baseGetFCNames(fcCache, users);
const getFCAvatarURLs: GetFCAvatarURLs = (
fids: $ReadOnlyArray<string>,
): Promise<BaseFCAvatarInfo[]> => baseGetFCAvatarURLs(fcCache, fids);
return { return {
client: neynarClient, client: neynarClient,
fcCache, fcCache,
getFCNames, getFCNames,
getFCAvatarURLs,
}; };
}, [neynarClient]); }, [neynarClient]);
return ( return (
<NeynarClientContext.Provider value={context}> <NeynarClientContext.Provider value={context}>
{children} {children}
</NeynarClientContext.Provider> </NeynarClientContext.Provider>
); );
} }
export { NeynarClientContext, NeynarClientProvider }; export { NeynarClientContext, NeynarClientProvider };
View Options

lib/shared/thread-utils.js

Loading...
View Options

native/chat/chat-thread-list.react.js

Loading...
View Options

native/chat/compose-thread-button.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/chat/thread-list-provider.js

Loading...
View Options

web/input/input-state-container.react.js

Loading...
View Options

web/utils/thread-utils.js

Loading...