Differential D14596 Authored by tomek on Apr 24 2025, 3:48 PM.
Details Summary Having both hooks and types in the same file causes an import cycle in the next diff. https://linear.app/comm/issue/ENG-10592/move-message-sending-logic-to-specs Depends on D14590 Test Plan Tested with the next diff by sending messages.
Diff Detail
Event TimelineHerald added a subscriber: ashoat. · View Herald TranscriptApr 24 2025, 3:48 PM2025-04-24 15:48:30 (UTC+0) Harbormaster completed remote builds in B34017: Diff 47851.Apr 24 2025, 4:26 PM2025-04-24 16:26:36 (UTC+0) This revision is now accepted and ready to land.Apr 25 2025, 10:46 AM2025-04-25 10:46:43 (UTC+0) Closed by commit rCOMM991c6bce86ec: [lib] Extract upload hooks from upload actions. · Explain WhyApr 28 2025, 10:43 AM2025-04-28 10:43:32 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 47874 |