Paths

Table of Contentst

Differential D14590

[lib] Create a thread protocol and move sending text message logic there
ClosedPublic
Actions

Authored by tomek on Apr 22 2025, 10:44 AM.

Tags

None

Referenced Files

	F32930978: D14590.1768238738.diff
	Sun, Jan 11, 5:25 PM

	F32930934: D14590.1768237605.diff
	Sun, Jan 11, 5:06 PM

	F32930107: D14590.1768235952.diff
	Sun, Jan 11, 4:39 PM

Subscribers

Details

Reviewers

kamil
angelika

Commits

rCOMM2b76b3bdea6f: [lib] Create a thread protocol and move sending text message logic there

Summary

Create a protocol spec, move sending text messages there, and use the protocol.

https://linear.app/comm/issue/ENG-10592/move-message-sending-logic-to-specs

Depends on D14589

Test Plan

Run the app and check if it is possible to send a text message in thin and thick threads.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 22 2025, 10:44 AM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 22 2025, 10:44 AM

Harbormaster completed remote builds in B34008: Diff 47841.Apr 22 2025, 11:01 AM

tomek requested review of this revision.Apr 22 2025, 11:01 AM

Rename

Harbormaster completed remote builds in B34010: Diff 47843.Apr 22 2025, 2:35 PM

I like the new design

lib/shared/threads/dm-thread-protocol.js
1 ↗	(On Diff #47843)	I would move it to some kind of `/protocols` directory but up to you
lib/shared/threads/thread-spec.js
27–30 ↗	(On Diff #47843)	I think using `Utils` seems too generic, maybe `Actions` or `Methods`?

This revision is now accepted and ready to land.Apr 23 2025, 9:57 AM

Create protocols directory

lib/shared/threads/dm-thread-protocol.js
1 ↗	(On Diff #47843)	Makes sense!
lib/shared/threads/thread-spec.js
27–30 ↗	(On Diff #47843)	I would keep this name, because for other methods it is indeed more generic and follows the pattern from `ProcessDMOperationUtilities`.

tomek added a child revision: D14593: [lib] Move sending multimedia messages to the protocol.Apr 23 2025, 2:33 PM

Harbormaster completed remote builds in B34013: Diff 47847.Apr 23 2025, 2:37 PM

tomek added a child revision: D14596: [lib] Extract upload hooks from upload actions.Apr 24 2025, 3:48 PM

tomek removed a child revision: D14593: [lib] Move sending multimedia messages to the protocol.Apr 24 2025, 3:49 PM

Closed by commit rCOMM2b76b3bdea6f: [lib] Create a thread protocol and move sending text message logic there. · Explain WhyApr 28 2025, 10:43 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM2b76b3bdea6f: [lib] Create a thread protocol and move sending text message logic there.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

input-state-container-hooks.js

81 lines

shared/

threads/

community-announcement-root-spec.js

2 lines

community-open-announcement-subthread-spec.js

2 lines

community-open-subthread-spec.js

2 lines

community-root-spec.js

2 lines

community-secret-announcement-subthread-spec.js

2 lines

community-secret-subthread-spec.js

2 lines

genesis-personal-spec.js

2 lines

genesis-private-spec.js

2 lines

genesis-spec.js

2 lines

2 lines

personal-spec.js

2 lines

private-spec.js

2 lines

protocols/

dm-thread-protocol.js

75 lines

keyserver-thread-protocol.js

37 lines

sidebar-spec.js

2 lines

thick-sidebar-spec.js

2 lines

29 lines

Diff 47873

lib/hooks/input-state-container-hooks.js

Loading...

lib/shared/threads/community-announcement-root-spec.js

Loading...

lib/shared/threads/community-open-announcement-subthread-spec.js

Loading...

lib/shared/threads/community-open-subthread-spec.js

Loading...

lib/shared/threads/community-root-spec.js

Loading...

lib/shared/threads/community-secret-announcement-subthread-spec.js

Loading...

lib/shared/threads/community-secret-subthread-spec.js

Loading...

lib/shared/threads/genesis-personal-spec.js

Loading...

lib/shared/threads/genesis-private-spec.js

Loading...

lib/shared/threads/genesis-spec.js

Loading...

lib/shared/threads/local-spec.js

Loading...

lib/shared/threads/personal-spec.js

Loading...

lib/shared/threads/private-spec.js

Loading...

lib/shared/threads/protocols/dm-thread-protocol.js

Loading...

lib/shared/threads/protocols/keyserver-thread-protocol.js

Loading...

lib/shared/threads/sidebar-spec.js

Loading...

lib/shared/threads/thick-sidebar-spec.js

Loading...

lib/shared/threads/thread-spec.js

Loading...