[lib] Move sidebar source deletion check to a spec
ClosedPublic
Actions

Authored by tomek on Apr 25 2025, 3:57 PM.

Details

Reviewers

kamil
angelika

Commits

rCOMMdecc45fa254f: [lib] Move sidebar source deletion check to a spec

Summary

Move the flag.

Depends on D14607

Test Plan

Check if sidebar sources can be deleted only in thin threads.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Apr 25 2025, 3:57 PM

Herald added a subscriber: ashoat. · View Herald TranscriptApr 25 2025, 3:57 PM

Harbormaster completed remote builds in B34032: Diff 47868.Apr 25 2025, 4:14 PM

tomek requested review of this revision.Apr 25 2025, 4:14 PM

tomek added a child revision: D14609: [lib] Move most of the UI differences to specs.Apr 25 2025, 5:32 PM

angelika accepted this revision.Apr 29 2025, 9:39 AM

angelika added inline comments.

lib/utils/delete-message-utils.js
120 ↗	(On Diff #47868)	I assume that this change is on purpose? Because we don't handle deleting sidebar source in thick threads and if user can delete all messages then it could lead to a bug?

This revision is now accepted and ready to land.Apr 29 2025, 9:39 AM

tomek added inline comments.May 7 2025, 4:47 PM

lib/utils/delete-message-utils.js
120 ↗	(On Diff #47868)	Yes exactly! It is a bugfix. I should've explained that in a comment.

Closed by commit rCOMMdecc45fa254f: [lib] Move sidebar source deletion check to a spec. · Explain WhyMay 8 2025, 11:29 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMdecc45fa254f: [lib] Move sidebar source deletion check to a spec.

Revision Contents
Changeset List

Path

Size

lib/

shared/

threads/

protocols/

dm-thread-protocol.js

2 lines

keyserver-thread-protocol.js

2 lines

thread-spec.js

1 line

utils/

delete-message-utils.js

16 lines

Diff 47978

View Options

lib/shared/threads/protocols/dm-thread-protocol.js

View Options

lib/shared/threads/protocols/keyserver-thread-protocol.js

View Options

lib/shared/threads/thread-spec.js

View Options

lib/utils/delete-message-utils.js

[lib] Move sidebar source deletion check to a specClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 47978

lib/shared/threads/protocols/dm-thread-protocol.js

lib/shared/threads/protocols/keyserver-thread-protocol.js

lib/shared/threads/thread-spec.js

lib/utils/delete-message-utils.js

[lib] Move sidebar source deletion check to a spec
ClosedPublic
Actions

Revision Contents
Changeset List