I don't understand why iconCreationFunction is introduced. Can't we just have chatThreadListIcon in specs that is lock, server or something else in the future (depends on the protocol)?

lib doesn't know and doesn't care about actual icons and components as it should
native does <Icon name={iconName} size={12} style={iconStyle} /> where iconName comes from specs (as it does now)
web does

const icon = iconName === 'lock' ? lock : server;
...
<FontAwesomeIcon size="xs" className={iconClass} icon={icon} />

where iconName comes from specs

In D14634#407366, @angelika wrote:
I don't understand why iconCreationFunction is introduced. Can't we just have chatThreadListIcon in specs that is lock, server or something else in the future (depends on the protocol)?

lib doesn't know and doesn't care about actual icons and components as it should

native does <Icon name={iconName} size={12} style={iconStyle} /> where iconName comes from specs (as it does now)

web does
const icon = iconName === 'lock' ? lock : server;
...
<FontAwesomeIcon size="xs" className={iconClass} icon={icon} />
where iconName comes from specs

Right, your idea is a lot simpler, thanks! Updating the diff.

Simplify

tomek edited the summary of this revision. (Show Details)May 22 2025, 1:04 PM

Harbormaster completed remote builds in B34238: Diff 48174.May 22 2025, 1:31 PM

angelika accepted this revision.May 23 2025, 1:11 AM

angelika added inline comments.

lib/shared/threads/protocols/keyserver-thread-protocol.js
359–360 ↗	(On Diff #48174)	do we need to separate native and web icons? I mean instead of `nativeChatThreadListIcon` and `webChatThreadListIcon` can we have just one `chatThreadListIcon`?

This revision is now accepted and ready to land.May 23 2025, 1:11 AM

tomek added inline comments.May 23 2025, 10:31 AM

lib/shared/threads/protocols/keyserver-thread-protocol.js
359–360 ↗	(On Diff #48174)	Was wondering about it, but I think this split can be beneficial if we want to introduce a different icon on different platforms.